Skip to content

fix(github): enforce persona/pubkey match and verify against server-computed payload #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prasanna8585 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(github): enforce persona/pubkey match and verify against server-computed payload #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion validator/github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,18 @@ func (gh *Github) Validate() (err error) {
if err != nil {
return xerrors.Errorf("error when recovering pubkey: %w", err)
}
if crypto.CompressedPubkeyHex(pubkey_recovered) != crypto.CompressedPubkeyHex(gh.Pubkey) {
return xerrors.Errorf(
"persona in gist (%s) does not match supplied public key (%s)",
crypto.CompressedPubkeyHex(pubkey_recovered),
crypto.CompressedPubkeyHex(gh.Pubkey),
)
}
signature, err := util.DecodeString(payload.Signature)
if err != nil {
return xerrors.Errorf("error when decoding signature: %w", err)
}
return crypto.ValidatePersonalSignature(payload.SignPayload, signature, pubkey_recovered)
return crypto.ValidatePersonalSignature(gh.SignaturePayload, signature, pubkey_recovered)
}

func (gh *Github) GetAltID() string {
Expand Down
Loading