Skip to content

Restore Android SDK versions config items#171

Open
unlocdavid wants to merge 2 commits into
NativePHP:mainfrom
unlocnl:feature/restore-android-sdk-config
Open

Restore Android SDK versions config items#171
unlocdavid wants to merge 2 commits into
NativePHP:mainfrom
unlocnl:feature/restore-android-sdk-config

Conversation

@unlocdavid

Copy link
Copy Markdown

The config had a documentation comment about the Android SDK versions, but the actual items were missing.

The config values were still being used in the codebase, but always fell back on defaults. Project specific overrides in .env couldn't be applied either.

This PR restores the config keys and values.

@shanerbaner82 shanerbaner82 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@unlocdavid

Copy link
Copy Markdown
Author

I fixed the formatting after failed Pint test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants