Skip to content

Promote release 1.2.1 to main - #195

Merged
syed-awsaf-informed merged 7 commits into
mainfrom
release/1.2.1
Jul 22, 2026
Merged

Promote release 1.2.1 to main#195
syed-awsaf-informed merged 7 commits into
mainfrom
release/1.2.1

Conversation

@syed-awsaf-informed

Copy link
Copy Markdown
Contributor

Promote release 1.2.1 to main

ndtp-repository-writer Bot and others added 7 commits March 26, 2026 15:27
Bumps [geekyeggo/delete-artifact](https://github.com/geekyeggo/delete-artifact) from 5.1.0 to 6.0.0.
- [Release notes](https://github.com/geekyeggo/delete-artifact/releases)
- [Changelog](https://github.com/GeekyEggo/delete-artifact/blob/main/CHANGELOG.md)
- [Commits](GeekyEggo/delete-artifact@f275313...176a747)

---
updated-dependencies:
- dependency-name: geekyeggo/delete-artifact
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 7.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4.6.2...bbbca2d)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5.0.0 to 8.0.1.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v5...3e5f45b)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.7.0 to 4.0.0.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@c94ce9f...b45d80f)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(ospo): rename national-digital-twin to national-node-net
Copilot AI review requested due to automatic review settings July 22, 2026 13:29
@github-actions

Copy link
Copy Markdown
Contributor

✅ OSS Checks Passed

All tracked OSS checks passed in this run.

📊 Total Files 🟢 Passed 🔴 Failed 🧮 Score
14 14 0 100%

Results from commit 9d304b1, view the full job summary↗️ for detailed results.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes release 1.2.1 to main by aligning repository/org references to National-Node-Net, updating CI/CD workflows and container metadata accordingly, and improving test isolation around PropertyUtil state.

Changes:

  • Updated documentation, Maven metadata, Docker labels, and compose examples to point at the new GitHub organisation/repository locations.
  • Updated GitHub Actions workflows (tooling versions, org/repo references, Sonar configuration) and added .trivyignore wiring for Trivy scans.
  • Improved test hygiene by clearing PropertyUtil between tests to avoid cross-test contamination.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/test/java/uk/gov/dbt/ndtp/federator/server/processor/file/FileKafkaEventMessageProcessorTest.java Adds @AfterEach to clear PropertyUtil to prevent test state leakage.
src/test/java/uk/gov/dbt/ndtp/federator/common/utils/PropertyUtilTest.java Adds @AfterEach cleanup for PropertyUtil in tests.
src/test/java/uk/gov/dbt/ndtp/federator/common/storage/provider/file/client/S3ClientFactoryTest.java Ensures PropertyUtil is cleared during teardown alongside S3 client reset.
src/test/java/uk/gov/dbt/ndtp/federator/client/grpc/GRPCFileClientTest.java Clears PropertyUtil before/after each test for isolation.
README.md Updates repository/documentation links and clone instructions to new org.
pom.xml Updates SCM/package URLs to new org and bumps Jackson property version.
mkdocs.yml Updates commented repo_url to new org.
docs/running-locally.md Updates Management Node and Maven package URLs to new org.
docs/index.md Mirrors README link updates for docs landing page.
docs/deployment.md Updates Management Node links and GHCR image org references.
docker/Dockerfile.server Updates OCI image source label to new org.
docker/Dockerfile.client Updates OCI image source label to new org.
docker/docker-compose-grpc.yml Updates example GHCR image references to new org.
CONTRIBUTING.md Updates repository links (issues, roadmap, contributors) to new org.
CHANGELOG.md Adds 1.2.1 entry documenting org-alignment changes.
ACKNOWLEDGEMENTS.md Updates contributors link to new org.
.trivyignore Introduces CVE ignore list used by Trivy scans.
.github/workflows/release.yaml Updates artifact tooling versions and aligns org-related workflow behavior.
.github/workflows/publish-github-release.yml Updates actions versions and release/SBOM publication steps.
.github/workflows/oss-checker.yml Aligns OSPO repo/org references and updates action versions.
.github/workflows/maven.yml Updates Sonar configuration, docker/login-action, artifact download action, and Trivy ignore file usage.
.github/workflows/docker-ghcr.yml Updates docker/login-action/artifact download action and Trivy ignore file usage.
.github/workflows/auto-back-merge.yml Aligns app-token secrets naming and updates github-script version.
.github/dependabot.yml Updates Maven registry URL to new org.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .trivyignore
Comment on lines +1 to +5
CVE-2026-54512
CVE-2026-54513
CVE-2026-42583
CVE-2026-33870
CVE-2026-42584
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@syed-awsaf-informed
syed-awsaf-informed merged commit d68506c into main Jul 22, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants