-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[BUG] Parquet reader can use an uninitialized required BINARY length under a null ancestor #23755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
852ddba
bugfix
abigalekim c942ed0
changes
abigalekim 4aa72b4
Merge branch 'main' into ak/parquet-reader-bugfix
abigalekim b6d3143
Merge branch 'main' into ak/parquet-reader-bugfix
abigalekim 6a5503d
Update cpp/src/io/parquet/page_decode.cuh
abigalekim 30fab0b
Merge branch 'main' into ak/parquet-reader-bugfix
abigalekim f464b0d
Update cpp/src/io/parquet/page_decode.cuh
abigalekim 1b257bf
Merge branch 'main' into ak/parquet-reader-bugfix
abigalekim 2d6d5bf
Fix parquet null zero-fill: resolve nesting level before call sites g…
abigalekim 9a02e44
Merge remote-tracking branch 'origin/ak/parquet-reader-bugfix' into a…
abigalekim 16c338e
Merge remote-tracking branch 'origin/ak/parquet-reader-bugfix' into a…
abigalekim 2279895
Merge branch 'ak/parquet-reader-bugfix' of github.com:abigalekim/cudf…
abigalekim 39d1867
coderabbit
abigalekim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find. unfortunately more needs to be fixed: zero_fill_null_positions_shared() won't even be called from most of the call-sites in this scenario because it's using the wrong valid_map and computing the wrong num_values (e.g. the call in page_data.cu). Perhaps this logic needs to be factored out into a utility function so it can be used at those locations as well.