Skip to content

Fix remaining native stream_ref call sites - #5067

Merged
mythrocks merged 4 commits into
NVIDIA:mainfrom
vyasr:codex/rebase-spark-stream-ref
Sep 2, 2026
Merged

Fix remaining native stream_ref call sites#5067
mythrocks merged 4 commits into
NVIDIA:mainfrom
vyasr:codex/rebase-spark-stream-ref

Conversation

@vyasr

@vyasr vyasr commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Updates the remaining native call sites that still assumed cudf::get_default_stream() exposes rmm::cuda_stream_view-style APIs. This fixes Spark JNI builds against NVIDIA/cudf#23770 by using cuda::stream_ref APIs in benchmark stream setup and the missed LIKE helper.\n\nTests not run locally. The failure was reproduced in the cudf PR Spark JNI CI job: NVIDIA/cudf#23770.

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR completes the native migration from rmm::cuda_stream_view-style access to cuda::stream_ref, aligning the remaining LIKE helper and NVBench stream setup with the updated cuDF revision.

  • Replaces legacy .value() stream-handle extraction with .get() in JSON benchmarks.
  • Migrates the LIKE helper’s stream parameters and default to cuda::stream_ref.
  • Advances the cuDF submodule to the revision supplying the updated stream APIs.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/main/cpp/src/like.hpp Updates the LIKE helper’s public native stream parameter and default to cuda::stream_ref.
src/main/cpp/src/like.cu Propagates cuda::stream_ref through pattern validation and the underlying cuDF LIKE operation.
src/main/cpp/benchmarks/from_json.cu Uses the cuda::stream_ref raw-handle accessor for all affected NVBench stream registrations.
src/main/cpp/benchmarks/from_json_to_structs.cu Updates the JSON-to-struct benchmark’s default-stream registration to the new accessor.
src/main/cpp/benchmarks/get_json_object.cu Updates JSON-object benchmark stream registration while retaining the same default-stream execution path.
thirdparty/cudf Advances cuDF to the revision associated with the native stream API migration.

Reviews (4): Last reviewed commit: "Update cudf submodule to latest main" | Re-trigger Greptile

@vyasr
vyasr force-pushed the codex/rebase-spark-stream-ref branch from 1ebb64c to 85df499 Compare September 1, 2026 19:15
@mythrocks
mythrocks self-requested a review September 1, 2026 22:10
Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
@vyasr
vyasr force-pushed the codex/rebase-spark-stream-ref branch from f939015 to 3530e0e Compare September 2, 2026 02:29
@mythrocks

Copy link
Copy Markdown
Collaborator

Build

@mythrocks
mythrocks merged commit 2f98cb2 into NVIDIA:main Sep 2, 2026
6 checks passed
@mythrocks

Copy link
Copy Markdown
Collaborator

This has been merged. Thank you for fixing this, @vyasr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants