Fix remaining native stream_ref call sites - #5067
Merged
Merged
Conversation
Contributor
Greptile SummaryThe PR completes the native migration from
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (4): Last reviewed commit: "Update cudf submodule to latest main" | Re-trigger Greptile |
vyasr
force-pushed
the
codex/rebase-spark-stream-ref
branch
from
September 1, 2026 19:15
1ebb64c to
85df499
Compare
mythrocks
self-requested a review
September 1, 2026 22:10
Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
vyasr
force-pushed
the
codex/rebase-spark-stream-ref
branch
from
September 2, 2026 02:29
f939015 to
3530e0e
Compare
Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
Collaborator
|
Build |
mythrocks
approved these changes
Sep 2, 2026
Collaborator
|
This has been merged. Thank you for fixing this, @vyasr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the remaining native call sites that still assumed cudf::get_default_stream() exposes rmm::cuda_stream_view-style APIs. This fixes Spark JNI builds against NVIDIA/cudf#23770 by using cuda::stream_ref APIs in benchmark stream setup and the missed LIKE helper.\n\nTests not run locally. The failure was reproduced in the cudf PR Spark JNI CI job: NVIDIA/cudf#23770.