Skip to content

Migrate native streams to cuda::stream_ref - #5053

Closed
vyasr wants to merge 3 commits into
NVIDIA:mainfrom
vyasr:codex/rebase-spark-stream-ref
Closed

Migrate native streams to cuda::stream_ref#5053
vyasr wants to merge 3 commits into
NVIDIA:mainfrom
vyasr:codex/rebase-spark-stream-ref

Conversation

@vyasr

@vyasr vyasr commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes NVIDIA/cudf-spark#15685

Related to NVIDIA/cudf#23636 and NVIDIA/cudf#23770.

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR mechanically migrates native CUDA stream interfaces from rmm::cuda_stream_view to cuda::stream_ref while preserving existing GPU operations.

  • Updates native declarations, definitions, helpers, and kernel launches to use cuda::stream_ref.
  • Replaces raw stream access and synchronization with get() and sync().
  • Updates native tests and NVBench stream adapters to compile against the migrated interfaces.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/main/cpp/src/bloom_filter.cu Migrates Bloom filter stream parameters, synchronization, and kernel-launch handle access to the new CUDA stream API.
src/main/cpp/src/hash/hash.hpp Updates the shared hashing API declarations, including SHA wrappers, to accept cuda::stream_ref.
src/main/cpp/src/row_conversion.cu Migrates row-conversion allocation, copy, and kernel operations to the new stream reference type.
src/main/cpp/src/protobuf/protobuf_kernels.cu Updates Protobuf kernel and helper stream plumbing without changing parsing or output behavior.
src/main/cpp/src/shuffle_split.cu Migrates shuffle-splitting stream propagation and raw CUDA handle access while retaining existing execution flow.
src/main/cpp/benchmarks/bloom_filter.cu Adapts the benchmark to obtain the raw stream with get() and synchronize through sync().

Reviews (3): Last reviewed commit: "Merge main into stream_ref branch" | Re-trigger Greptile

vyasr added 2 commits August 28, 2026 13:10
Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
@vyasr

vyasr commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

This is a current-main replacement for the now-conflicting #5014. It carries the native stream migration needed after NVIDIA/cudf#23770 changes cuDF stream APIs to cuda::stream_ref.

All checks on this PR are green. Once this merges, we can rerun the remaining spark-rapids-jni job on NVIDIA/cudf#23770.

@vyasr

vyasr commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

My agent got trigger-happy and opened this. I will close for now in favor of #5014, but we can reopen this or cherry-pick changes from here onto #5014 as desired.

@vyasr vyasr closed this Aug 28, 2026
Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com>
@vyasr vyasr reopened this Aug 29, 2026
@vyasr vyasr closed this Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants