Skip to content

[dev] Fix HybridEP token equalization under torch.compile without CUDA graphs#5668

Open
HaochenYuan wants to merge 2 commits into
NVIDIA:devfrom
HaochenYuan:fix/hybridep-static-padding-detection
Open

[dev] Fix HybridEP token equalization under torch.compile without CUDA graphs#5668
HaochenYuan wants to merge 2 commits into
NVIDIA:devfrom
HaochenYuan:fix/hybridep-static-padding-detection

Conversation

@HaochenYuan

@HaochenYuan HaochenYuan commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

This PR fixes HybridEP token-count equalization when using torch.compile without CUDA Graphs. Previously, torch.compiler.is_compiling() incorrectly implied that inputs were statically padded, causing ranks with different token counts to skip the group-wide MAX.
The fix derives static token equality from the THD padding configuration: only max-padded inputs skip the collective, while unpadded or alignment-only inputs are equalized across ranks.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

Signed-off-by: HaochenYuan <haocheny@nvidia.com>
Signed-off-by: HaochenYuan <haocheny@nvidia.com>
@HaochenYuan HaochenYuan requested review from a team as code owners July 6, 2026 11:24
@HaochenYuan HaochenYuan changed the title Fix/hybridep static padding detection [dev] Fix/hybridep static padding detection Jul 6, 2026
@HaochenYuan HaochenYuan changed the title [dev] Fix/hybridep static padding detection [dev] Fix HybridEP token equalization under torch.compile without CUDA graphs Jul 6, 2026
@HaochenYuan HaochenYuan requested a review from xiaoyao0115 July 6, 2026 11:33

@xiaoyao0115 xiaoyao0115 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants