test: AUT-683 add unit tests for tensorboard-logs golden-value collection and common helpers#5653
Draft
svcnemo-autobot wants to merge 5 commits into
Draft
test: AUT-683 add unit tests for tensorboard-logs golden-value collection and common helpers#5653svcnemo-autobot wants to merge 5 commits into
svcnemo-autobot wants to merge 5 commits into
Conversation
…nd common helpers Covers previously untested code in tests/functional_tests/python_test_utils: - collect_train_test_metrics CLI (whitelist metric filtering, output JSON, no-logs warning path, optional output-path, convergence vs normal index selection, step-size forwarding) - common.read_golden_values_from_json (round-trip, pathlib input, missing-file) - common.GoldenValueMetric.__repr__ and GoldenValues RootModel round-trip
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
Collaborator
Author
|
/ok to test 3e4f518 |
Collapse multi-line import and call sites onto single lines to satisfy the repo's black config (--skip-magic-trailing-comma), fixing the linting check.
Collaborator
Author
|
/ok to test 06f9ddb |
CI's unit-test launcher only discovers tests under tests/unit_tests, so the new coverage was never actually executed from the functional_tests location. Relocate the file there (imports are absolute and unchanged) per review.
The tensorboard-logs util tests now live in tests/unit_tests where CI runs them; leave a pointer here with no test functions to avoid duplicate collection.
Collaborator
Author
|
/ok to test c2fb5c6 |
The tests now live in tests/unit_tests where CI discovers and runs them; delete the leftover file at the old functional_tests path per review.
Collaborator
Author
|
/ok to test 3af99c0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
test_get_test_results_from_tensorboard_logs.pycovering the previously untestedcollect_train_test_metricsCLI (metric whitelist filtering, JSON output, no-logs warning path, index/step-size option forwarding) and the untestedcommonhelpersread_golden_values_from_json,GoldenValueMetric.__repr__, and theGoldenValuesRootModel round-trip. Assumed unit-level coverage (mockingread_tb_logs_as_list) is desired rather than end-to-end tests that write real TensorBoard event files; if you'd prefer real-event-file coverage ofread_tb_logs_as_list/_load_event_accumulators_with_scalars, comment and I'll add it.