Fix order-dependent weight validation in get_blend_from_list#5648
Draft
Anurag461 wants to merge 1 commit into
Draft
Fix order-dependent weight validation in get_blend_from_list#5648Anurag461 wants to merge 1 commit into
Anurag461 wants to merge 1 commit into
Conversation
any(...) and all(...) shared a single-use map() iterator, so the mixed weighted/bare-prefix check depended on the position of the first unparseable weight (e.g. ['30','a','b','c'] slipped through while ['a','b','70','c'] was rejected). Materialize the check into a list and add a regression test. Signed-off-by: Anurag Kashyap <anurag1457@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_blend_from_list shared a single-use map() iterator between any(...) and all(...), so the mixed weighted/bare-prefix validation depended on the position of the first unparseable weight: ['30','a','b','c'] was silently accepted (mis-parsed) while ['a','b','70','c'] raised. Fix materializes the check into a list and adds an explanatory assertion message; behavior is now order-independent. Adds tests/unit_tests/data/test_utils.py, whose parametrized mixed-weight case fails on main and passes with this change.