avoid circular dependency usage between mcore and modelopt#5644
Open
dimapihtar wants to merge 19 commits into
Open
avoid circular dependency usage between mcore and modelopt#5644dimapihtar wants to merge 19 commits into
dimapihtar wants to merge 19 commits into
Conversation
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
dimapihtar
added
complexity: low
Expert Review
Contributor
Author
|
/ok to test 75b1e68 |
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Contributor
Author
|
/ok to test f52c7bb |
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Contributor
Author
|
/ok to test f9a7a8e |
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Contributor
Author
|
/ok to test de51811 |
| import modelopt.torch.opt as mto | ||
| import modelopt.torch.utils.distributed as dist | ||
|
|
||
| has_nvidia_modelopt = True |
Contributor
There was a problem hiding this comment.
Where is has_nvidia_modelopt used?
Contributor
Author
There was a problem hiding this comment.
just a default style of guarding in mcore
AAnoosheh
requested changes
Jul 6, 2026
AAnoosheh
left a comment
AAnoosheh
left a comment
Contributor
There was a problem hiding this comment.
IMPORTANT: Don't merge as we have further inquiries to the consequences of this change. (See Slack thread)
Co-authored-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.