Add CUDA 13.4 build configuration - #6478
Conversation
(cherry picked from commit 5f5b3aba87eb205d1aae5c9e4c378eda309fb1a7) Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
|
@greptile review |
|
CI MESSAGE: [67060476]: BUILD STARTED |
|
CI MESSAGE: [67060476]: BUILD FAILED |
|
CI MESSAGE: [67108784]: BUILD STARTED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [67108784]: BUILD FAILED |
|
CI MESSAGE: [67108784]: BUILD PASSED |
jantonguirao
left a comment
There was a problem hiding this comment.
Reviewed the diff (2 new Dockerfiles + build.sh + docs/compilation.rst).
Verified the version bump is consistent with the existing 13.0–13.3 pattern: Dockerfile.cuda134.{x86_64,aarch64}.deps follow the same structure as Dockerfile.cuda133.*.deps (same package list, same NVCOMP archive URL pattern, same fatbinary wrapper — just rewritten as individual echo >> lines instead of one embedded \n-escaped string, which is a robustness improvement, not a behavior change). docker/build.sh's Dockerfile selection is by filename convention (Dockerfile.cuda${CUDA_VER}.${ARCH}.deps), which resolves correctly for CUDA_VER=134. Docs (compilation.rst) and the CUDA_VERSION validation list were both updated consistently.
All three Greptile findings from the first review round (wrong default in help text, nvCOMP version mismatch 5.2.0.10 vs 5.3.0.16, missing terminal punctuation in the error message) are fixed in the follow-up commit ed15c41 — confirmed against the current diff, not just the bot's say-so. The later Greptile comments about docker/repro-nvimgcodec-issue55/* are stale/misattributed — those files aren't part of this PR's diff at all.
Two pre-existing, out-of-scope observations (not blocking, not introduced by this PR, so no inline comments):
Dockerfile.cuda133.*.depsis missinglibnvjpeg/libnvjpeg-dev(present in 13.0–13.2 and correctly restored in the new 13.4 files) — looks like a regression that crept into 13.3, worth a follow-up fix there.- The
CREATE_RUNNER=YESpath inbuild.sh(~line 325) only setsCUDA_IMAGE_NAMEfor CUDA_VER 120/130 and falls through to "Not supported CUDA version" for everything else, including 131/132/133 and now 134 — predates this PR (introduced 2026-07-13), so out of scope here.
No blocking issues. Approving.
Category:
Other (Configuration)
Description:
Add CUDA 13.4 dependency-image configurations for x86_64 and aarch64, make
CUDA 13.4 the default Docker build version, and update the compilation
documentation.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
versions.
public NVIDIA developer-download repository.
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-4810