Skip to content

fix(aggregate-results): wrong unit for 125k bandwidth JSON (+1 more) #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(aggregate-results): wrong unit for 125k bandwidth JSON (+1 more) #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions bobber/lib/analysis/aggregate_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: MIT
from functools import wraps
from typing import NoReturn


def average_decorator(func: 'method') -> float:
Expand Down Expand Up @@ -113,7 +112,7 @@ def __init__(self,
bytes_sizes: dict,
dali_results: dict,
metadata: dict,
systems: int) -> NoReturn:
systems: int) -> None:
self._read_bw = read_bw
self._read_bw_params = read_bw_params
self._read_iops = read_iops
Expand Down Expand Up @@ -304,7 +303,7 @@ def json(self) -> dict:
'125k_bandwidth': {
'read': self._average_125k_read_bw(),
'write': self._average_125k_write_bw(),
'unit': 'operations/second',
'unit': 'bytes/second',
'parameters': {
'read': self._125k_read_bw_params,
'write': self._125k_write_bw_params
Expand Down