Skip to content

fix: save_config annotated as NoReturn but returns None #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: save_config annotated as NoReturn but returns None #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bobber/bobber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def load_from_config(config_path: str) -> Namespace:
return Namespace(**settings)


def save_config(args: Namespace) -> NoReturn:
def save_config(args: Namespace) -> None:
"""
Save the settings as JSON.

Expand All @@ -307,6 +307,7 @@ def save_config(args: Namespace) -> NoReturn:
settings = vars(args)
with open(f'{args.log_path}/command_parameters.json', 'w') as fp:
fp.write(json.dumps(settings))
return None


def load_settings(args: Namespace) -> Namespace:
Expand Down