fix(mtp): enable activation checkpointing for repeated dense MTP blocks - #3660
Open
pzelasko wants to merge 2 commits into
Open
fix(mtp): enable activation checkpointing for repeated dense MTP blocks#3660pzelasko wants to merge 2 commits into
pzelasko wants to merge 2 commits into
Conversation
Contributor
|
/ok to test 0a84773 |
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
pzelasko
force-pushed
the
codex/mtp-attention-ac
branch
from
August 26, 2026 17:41
0a84773 to
7e822a3
Compare
pzelasko
changed the title
Contributor
Author
|
/ok to test 7e822a3 |
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Contributor
Author
|
/ok to test dfbfbfa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This enables activation checkpointing for attention-only repeated MTP configurations used by SpeechLM while preserving the existing safety workaround for shared expert parameters.
Tests
pytest -q tests/unit_tests/moe/test_parallelizer.py— 87 passedpython -m ruff check nemo_automodel/components/moe/parallelizer.py tests/unit_tests/moe/test_parallelizer.py— passed