Skip to content

feature: GPU hardware detection for orchestrated backend#505

Merged
romanc merged 7 commits into
NOAA-GFDL:developfrom
romanc:romanc/gpu-hw-config
Jul 16, 2026
Merged

feature: GPU hardware detection for orchestrated backend#505
romanc merged 7 commits into
NOAA-GFDL:developfrom
romanc:romanc/gpu-hw-config

Conversation

@romanc

@romanc romanc commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR pulls out GPU hardware detection of the orchestrated dace backends from PR #465.

How has this been tested?

Mainly tested by running simulations as part of the June push (as part of PR #465). Added very simplistic test cases to cover the basics. It's kinda hard to check for hw detection (because you can't really know the hw you are running on).

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. add new modules to docs/docstrings/)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included

@romanc
romanc requested a review from twicki July 14, 2026 10:03
@romanc romanc changed the title Romanc/gpu hw config feature: GPU hardware detection for orchestrated backends Jul 14, 2026
@romanc romanc changed the title feature: GPU hardware detection for orchestrated backends feature: GPU hardware detection for orchestrated backend Jul 14, 2026

@twicki twicki left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this we currently still have no way of manually overwriting this, correct?

The more we do, the more we need a config of our own. But having this as the default is already better than what we had before

@romanc

romanc commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

With this we currently still have no way of manually overwriting this, correct?

Correct - there's no way (without code changes) to change these defaults.

The more we do, the more we need a config of our own. But having this as the default is already better than what we had before

Agreed, the need for an NDSL-level config file gets more and more apparent.This is another good example.

@romanc
romanc added this pull request to the merge queue Jul 16, 2026
Merged via the queue into NOAA-GFDL:develop with commit b0b3869 Jul 16, 2026
9 checks passed
@romanc
romanc deleted the romanc/gpu-hw-config branch July 17, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants