Adds share feature in map control plugin, reusing adapters from share export plugin. #209
Draft
BhattaraiSijan wants to merge 1 commit into
Draft
Adds share feature in map control plugin, reusing adapters from share export plugin. #209BhattaraiSijan wants to merge 1 commit into
BhattaraiSijan wants to merge 1 commit into
Conversation
…shareexport plugin to shared adapters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Share map button to the MapControl bar, reusing ShareExport's existing share feature end-to-end.
shareActions/sharePdf/downloadfrom ShareExport toTools/_shared/adapters/— the copy-link / export-PNG / export-PDF logic is plugin-agnostic (it reaches core only over the bus:map:writeCoordinateURL,map:getScreenshot,app:copyText), so any plugin can now host an export feature. ShareExport's only change is the import path.endSlot— the lib stays MMGIS-free; the adapter fills the slot with ShareExport'sShareMenucomponent (identical dropdown/behavior), with the trigger restyled to the Figma design (dark filled button, USWDS tokens) via a CSS override scoped to the bar.Sharetoggle in MapControl's Configure options (default on).ShareExport still works standalone and is visually unchanged. Note: enabling both plugins in one mission shows two share buttons — pick one via config (float-zone layout discussion: #203).
Testing
Manual: share button renders at the right end of the bar; copy link / PNG / PDF work from it; ShareExport's own card unaffected.
tscclean, 786 unit tests + e2e smoke pass.