Repository navigation
Switch to floor division in pager.py - #1466
Merged
Merged
Conversation
Implementing Tom Peterson's suggested fix for a crash caused by the default division behavior of Python 3. With a single slash '/', Python 3 gives a floating point result. Python 2 used to provide an integer result. In pager.py, division is used to calculate a page offset, which needs to be an integer value. To enforce this under Python 3, the code has been updated to use "floor division" by using two slashes '//'. This provides an integer result which will prevent a crash. Resolves MythTV#1426
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing Tom Peterson's suggested fix for a crash caused by the default division behavior of Python 3. With a single slash '/', Python 3 gives a floating point result. Python 2 used to provide an integer result. In pager.py, division is used to calculate a page offset, which needs to be an integer value. To enforce this under Python 3, the code has been updated to use "floor division" by using two slashes '//'. This provides an integer result which will prevent a crash.
Resolves #1426
Checklist