Repository navigation
Chore/dev tooling upgrade - #40
Merged
Merged
Conversation
- pyproject.toml: add pyright>=1.1.408 to dev deps; add [tool.pyright] config (basic mode, targeted excludes for mujoco-uni/mlx stubs); add ruff src=["unilab"] for correct first-party import detection; tighten coverage omit to */rsl_rl/* glob - Makefile: `make type` now runs mypy + pyright in sequence - .pre-commit-config.yaml: ruff v0.8.4 → v0.14.14; replace mirrors-mypy hook with RobertCraigie/pyright-python v1.1.408 - .github/workflows/ci.yml: add global UV_FROZEN=1; add paths-ignore for docs/md/LICENSE changes; upgrade setup-uv v5→v6; pass python-version matrix param to setup-uv; typecheck job now runs both mypy and pyright - CLAUDE.md / CONTRIBUTING.md: sync make type description and CI table Type fixes to make pyright pass (0 errors, 7 warnings): - base/base.py: add abstract state/init_state/step/close to ABEnv interface - tests/: update _DummyEnv and _TestEnvA stubs to implement new ABEnv methods - algos/torch/appo/runner.py: assert observation/action shape not None - algos/torch/offpolicy/worker.py: assert observation/action shape not None - algos/torch/appo/learner.py: pyright ignore on vendored resolve_optimizer - algos/torch/fast_sac/learner.py: pyright ignore on torch.amp private API - base/backend/motrix_backend.py: pyright ignore on possibly-unbound mtx - utils/offpolicy_logger.py: type log_dict as dict[str, Any]; add Any import - utils/onpolicy_logger.py: type log_dict as dict[str, Any] - utils/torch_utils.py: pyright ignore on torch.from_dlpack private API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.