Repository navigation
fix: remove unnecessary np.asarray in motrix backend & bump motrixsim - #293
Merged
Merged
Conversation
- Remove redundant np.asarray calls in motrix backend: motrixsim C++ bindings already return numpy arrays. Simplify np.asarray(...).copy() to np.array(...) and drop np.asarray on fields already typed as np.ndarray. Retain only where explicit dtype conversion is needed. - Bump motrixsim to 0.7.1.dev95684 and add motphys-pypi index.
…ecessary-np-asarray # Conflicts: # pyproject.toml
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
…np-asarray fix: remove unnecessary np.asarray in motrix backend & bump motrixsim
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
…np-asarray fix: remove unnecessary np.asarray in motrix backend & bump motrixsim
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
…np-asarray fix: remove unnecessary np.asarray in motrix backend & bump motrixsim
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.asarraycalls inmotrix_backend.py: motrixsim C++ bindings already return numpy arraysnp.asarray(...).copy()→np.array(...)(np.array copies by default)np.asarrayon dataclass fields already typed asnp.ndarraynp.asarrayonly where explicit dtype conversion is needed (dtype=np.intp,dtype=np.int32)Related
Test plan