Skip to content

fix: respect user GL override in render probe - #288

Merged
TATP-233 merged 1 commit into
mainfrom
fix/macos-render-many-egl-test
Apr 16, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/macos-render-many-egl-test

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • Fix render_many GL backend resolution so only user-provided MUJOCO_GL overrides are preserved on Linux.
  • Avoid treating the module's own import-time fallback (glfw on macOS hosts probing Linux behavior in tests) as an explicit override.
  • Restore the expected EGL probe behavior in the macOS unit test path.

Linked Work

  • Issue: N/A
  • Milestone: N/A

Validation

  • make check
  • uv run pytest -m "not slow"
  • Additional task-specific validation listed below

Commands actually run:

uv run pytest tests/utils/test_render_many.py -q
make check
make test

Impact

  • Backend impact: mujoco
  • Platform impact: both
  • Training effect expected: no

Artifacts

  • W&B: N/A
  • benchmark result: N/A
  • video / screenshot: N/A
  • ONNX / checkpoint: N/A

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed
  • Linked the driving issue
  • Noted any follow-up work explicitly

@TATP-233 TATP-233 mentioned this pull request Apr 16, 2026
3 of 7 tasks
@TATP-233 TATP-233 closed this Apr 16, 2026
@TATP-233 TATP-233 reopened this Apr 16, 2026
@TATP-233
TATP-233 merged commit 848e10a into main Apr 16, 2026
9 of 19 checks passed
@TATP-233
TATP-233 deleted the fix/macos-render-many-egl-test branch April 16, 2026 20:42
TATP-233 added a commit that referenced this pull request May 4, 2026
fix: respect user GL override in render probe
TATP-233 added a commit that referenced this pull request May 30, 2026
fix: respect user GL override in render probe
TATP-233 added a commit that referenced this pull request Sep 4, 2026
fix: respect user GL override in render probe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant