Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/unilab/rl/logging/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def finish(self, *, title: str = "Training Summary", extra_summary: str = ""):
return
self._stop_live()

elapsed = time.time() - self._start_time
elapsed = time.time() - self._start_time if self._start_time else 0.0
if not self._no_print:
summary = (
f"[bold green]Training complete[/]\n"
Expand Down
7 changes: 6 additions & 1 deletion src/unilab/rl/runtime/offpolicy/double_buffer_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -1074,6 +1074,12 @@ def _wait_for_inference_request(
if self._collector_ready:
raise RuntimeError("Collector sent duplicate ready signal")
self._collector_ready = True
# The ready signal marks the end of cold-path startup on both
# sides: learner compile/capture ran before the training loop
# and collector env construction precedes this publish. Open
# the live terminal display only now so startup output cannot
# interleave with Live redraws.
logger.start()
continue
if not self._collector_ready:
raise RuntimeError(
Expand Down Expand Up @@ -1678,7 +1684,6 @@ def _learn_impl(
f"Replay learner lightweight: batched event write (log_interval={self.log_interval})"
)
self._active_logger = logger
logger.start()
try:
self._shutdown_recorder.set_phase(owner="learner", phase="startup/dp_init")
# --- inference coordination queues ---
Expand Down
Loading