Repository navigation
fix: align timeout bootstrap with final observation contract - #240
Merged
Merged
Conversation
This reverts commit 23ca79d.
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
…trap fix: align timeout bootstrap with final observation contract
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
…trap fix: align timeout bootstrap with final observation contract
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
…trap fix: align timeout bootstrap with final observation contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #236
Summary
final_observationcontract instead of reusingV(obs_t)final_observationhandling behind a shared transition-bootstrap contract instead of duplicating worker-side patching rulesImpact
Validation
UV_CACHE_DIR=/tmp/uv-cache make checkUV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/utils/test_final_observation.py tests/algos/test_rsl_rl_ppo.py tests/algos/test_appo_worker.py tests/config/test_locomotion_params.py -qUV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/utils/test_final_observation.py tests/algos/test_rsl_rl_ppo.py tests/algos/test_appo_worker.py tests/config/test_locomotion_params.py tests/scripts/test_train_scripts.py -k 'test_play_wrapper_step_exports_timeout_bootstrap_obs or test_play_wrapper_policy_obs_mode_actor or test_play_wrapper_uses_current_reset_contract or test_ppo_hydra_default_algo_log_name' -qNotes
tests/scripts/test_train_scripts.py -k test_mlx_time_limit_bootstrap_values_use_final_observationstill aborts locally because importingscripts/train_mlx_ppo.pytriggers a nativemlxextension crash in this machine's environment.