Skip to content

fix: isolate G1 motion tracking backend hooks - #230

Merged
TATP-233 merged 2 commits into
mainfrom
fix/issue-217-228-g1-motion-tracking-backend-isolation
Apr 12, 2026
Merged

TATP-233 merged 2 commits into
mainfrom
fix/issue-217-228-g1-motion-tracking-backend-isolation

Conversation

@TATP-233

@TATP-233 TATP-233 commented Apr 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • move G1 motion tracking motion body-id resolution out of tracking.py and into backend-owned get_motion_body_ids() hooks
  • keep G1 motion tracking env backend-agnostic by removing explicit backend-name checks and leaving action-scale behavior unchanged
  • add initialization and cross-backend coverage for motion body-id resolution, including G1 motion tracking reset/step smoke on both backends

Linked Work

Validation

  • make check
  • make test
  • Additional task-specific validation listed below

Commands actually run:

make check
make test
uv run pytest tests/envs/test_env_configs.py -q -k g1_motion_tracking
uv run pytest tests/base/test_sim_backend.py -q -m slow -k motion_body_ids_match_motion_xml

Impact

  • Backend impact: both
  • Platform impact: both
  • Training effect expected: no

Artifacts

  • W&B:
  • benchmark result:
  • video / screenshot:
  • ONNX / checkpoint:

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed
  • Linked the driving issue
  • Noted any follow-up work explicitly

@TATP-233
TATP-233 merged commit 0134e2a into main Apr 12, 2026
5 checks passed
@TATP-233
TATP-233 deleted the fix/issue-217-228-g1-motion-tracking-backend-isolation branch April 12, 2026 09:43
TATP-233 added a commit that referenced this pull request May 4, 2026
…acking-backend-isolation

fix: isolate G1 motion tracking backend hooks
TATP-233 added a commit that referenced this pull request May 30, 2026
…acking-backend-isolation

fix: isolate G1 motion tracking backend hooks
TATP-233 added a commit that referenced this pull request Sep 4, 2026
…acking-backend-isolation

fix: isolate G1 motion tracking backend hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infra: Eliminate backend-type check in motion tracking task layer Work: 消除 G1 motion tracking env 中的 backend-specific 分支泄漏

1 participant