Repository navigation
fix(training): keep MuJoCo collector tensors on CPU by default - #2101
Merged
Merged
Conversation
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
training.collector_tensor_device: cpu | cudato the SAC, FlashSAC, PPO, and APPO training owners, withcpuas the default.manager_torch_device). An unindexedcudarequest is resolved by the environment to the current rank-local Torch CUDA ordinal.HOST_BRIDGEcollector/Manager carrier to CUDA. Non-MuJoCo CUDA requests fail closed;DEVICE_RESIDENTbackends continue to own their GPU placement.Linked Work
docs/sphinx/source/adr/ADR-0012-sole-tensor-manager-and-scoped-backends.mdmainValidation
make test-allpassed on the final local head before this PR was createdCommands actually run:
Complete default SAC validation:
Result:
run_summary.jsontail FPS:93,873.5; TensorBoard last-80 median FPS:97,666.7.apply_action:0.279 ms.collector_tensor_native=false,env_public_device=cpu, CPU inference transport, andlearner_device=cuda:0.logs/sac/G1WalkFlat/2026-10-09_13-49-45_mujoco/run_summary.json.Explicit CUDA smoke:
Result: completed 10/10 iterations with
collector_tensor_native=true,env_public_device=cuda:0, and CUDA inference transport.Remote CI route:
main: current-head CI passed at commit5290ed822935bf2090d816cd899789b7531e4147.Impact
mujocoArtifacts
run_summary.jsonfiles cited aboveChecklist
Follow-up: none required by this scoped change. Motrix/Drake/Superdex remain intentionally outside the #2100 backend boundary.