Skip to content

chore(motion): remove unused FlashSAC owner contract - #2076

Merged
TATP-233 merged 2 commits into
mainfrom
chore/remove-flashsac-owner-contract
Oct 8, 2026
Merged

TATP-233 merged 2 commits into
mainfrom
chore/remove-flashsac-owner-contract

Conversation

@TATP-233

@TATP-233 TATP-233 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the unused G1 FlashSAC semantic-owner fingerprint module and its dedicated contract tests.
  • Preserve the Motrix Manager runtime registration assertion in the package-boundary suite.
  • Replace the stale direct-runtime attribute assertions with a source-file absence check.
  • Remove stale ADR evidence references to the deleted fingerprint module.
  • No user-facing, backend, platform, or training behavior changes are expected; runtime code had no caller for the removed module.

Linked Work

Validation

  • make test-all passed on the final local head before this PR was created or updated
  • Additional task-specific validation listed below

Commands actually run:

uv run pytest tests/tasks/test_package_boundary.py tests/config/test_g1_motion_tracking_owners.py
uv run pytest tests/scripts/test_check_docs.py -q
make check
make test
mkdir -p /tmp/ul && TMPDIR=/tmp/ul/ make test-all
git diff --check

make test initially failed 7 Unix-socket tests with OSError: AF_UNIX path too long under the default macOS temporary-directory path. Rerunning the required final gate with a shorter TMPDIR passed. The successful make test-all result covers formatting, type checks, 1781 non-slow tests, and benchmark smoke imports.

Remote CI route:

Impact

  • Backend impact: none
  • Platform impact: none
  • Training effect expected: no

Artifacts

  • W&B: none
  • benchmark result: none
  • video / screenshot: none
  • ONNX / checkpoint: none

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed
  • Linked the driving issue
  • Noted any follow-up work explicitly

@TATP-233
TATP-233 requested a review from caozx1110 as a code owner October 8, 2026 11:10
@TATP-233
TATP-233 merged commit 2e1c6de into main Oct 8, 2026
8 checks passed
@TATP-233
TATP-233 deleted the chore/remove-flashsac-owner-contract branch October 8, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant