Repository navigation
fix: restore go1 reset domain randomization path - #187
Merged
Merged
Conversation
5 tasks
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
fix: restore go1 reset domain randomization path
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
fix: restore go1 reset domain randomization path
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
fix: restore go1 reset domain randomization path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go1WalkTask.reset()override so Go1 uses the sharedNpEnv -> DomainRandomizationManagerreset flow againIssue
Closes #173
Validation
UV_CACHE_DIR=.uv-cache make checkUV_CACHE_DIR=.uv-cache uv run ruff check src/unilab/envs/locomotion/go1/joystick.py tests/envs/test_go1_domain_randomization.pyUV_CACHE_DIR=.uv-cache uv run pyright tests/envs/test_go1_domain_randomization.pyUV_CACHE_DIR=.uv-cache uv run pytest tests/envs/test_go1_domain_randomization.py tests/envs/test_env_configs.py -q -k "go1_mujoco_reset_applies_base_mass_and_com_domain_randomization or go2_mujoco_reset_applies_kp_kd_domain_randomization"UV_CACHE_DIR=.uv-cache uv run pytest tests/integration/test_reward_injection_integration.py -qUV_CACHE_DIR=.uv-cache uv run pytest tests/config/test_config_system.py -q -k "go1_joystick or Go1JoystickFlatTerrain"Known local failures
UV_CACHE_DIR=.uv-cache uv run pre-commit run --all-filesstill fails on existing repo-widepyright/mypyissues outside this change (for examplebenchmark/and several pre-existing test typing paths).UV_CACHE_DIR=.uv-cache make testaborts while collectingtests/algos/test_mlx_ppo.pydue a local MLX runtime crash.UV_CACHE_DIR=.uv-cache uv run python scripts/train_rsl_rl.py task=go1_joystick training.sim_backend=mujoco algo.max_iterations=1also aborts in the same local MLX runtime path before reaching Go1 training execution.