Repository navigation
refactor: extract shared training entrypoint helpers - #185
Merged
Merged
Conversation
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
…mmon refactor: extract shared training entrypoint helpers
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
…mmon refactor: extract shared training entrypoint helpers
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
…mmon refactor: extract shared training entrypoint helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/unilab/training/common.pysrc/unilab/training/backend_adapter.pyto centralizemotrix_legacy/motrix_play_onlyconfig adaptationtrain_rsl_rl.py,train_appo.py,train_offpolicy.py, andtrain_mlx_ppo.pyto use the shared helpers while preserving script-level compatibility wrappers used by testsLinked Work
Validation
make checkmake testCommands actually run:
uv run python -m py_compile scripts/train_rsl_rl.py scripts/train_appo.py scripts/train_offpolicy.py scripts/train_mlx_ppo.py src/unilab/training/common.py src/unilab/training/backend_adapter.py src/unilab/training/__init__.py uv run ruff check scripts/train_rsl_rl.py scripts/train_appo.py scripts/train_offpolicy.py scripts/train_mlx_ppo.py src/unilab/training/common.py src/unilab/training/backend_adapter.py src/unilab/training/__init__.py uv run pytest tests/training/test_training_helpers.py tests/scripts/test_train_scripts.py -q make check make test UV_CACHE_DIR=.uv-cache uv run pre-commit run --all-filesNotes:
UV_CACHE_DIR=.uv-cache uv run pre-commit run --all-filesstill reports existingpyright/mypyfailures outside this change set, mainly underbenchmark/, tests, and legacy script typing paths.make checkandmake testpass for the current branch.Impact
Artifacts
Checklist
Follow-up work:
pyright/mypyfailures that currently causepre-commit --all-filesto fail outside this refactor scope