Skip to content

cleanup: remove legacy TaskRegistry - #179

Merged
TATP-233 merged 1 commit into
mainfrom
fix/issue-172-remove-task-registry
Apr 9, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/issue-172-remove-task-registry

Conversation

@TATP-233

@TATP-233 TATP-233 commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR addresses issue #172 by removing the legacy TaskRegistry that duplicates functionality with the new unified registry system.

Changes

  • Deleted src/unilab/envs/locomotion/task_registry.py (19 lines)

Migration Status

All locomotion environments have already been migrated to the new registry system:

  • Use @registry.envcfg("EnvName") decorator for config registration
  • Use @registry.env("EnvName", sim_backend="xxx") decorator for env registration

Verification

  • grep -r "task_registry" src/ - no references found
  • All tests pass (353 passed, 5 skipped)
  • Locomotion environments register correctly via new system:
    • Go2JoystickFlatTerrain
    • Go1JoystickFlatTerrain
    • G1JoystickFlatTerrain
    • G1WalkTaskMjSAC

Definition of Done

  • All references migrated to registry.py
  • task_registry.py deleted
  • No functional regression
  • CI green

Fixes #172

Remove the legacy TaskRegistry in favor of the unified registry system:

- Delete src/unilab/envs/locomotion/task_registry.py (19 lines)
- All locomotion environments already use @registry.envcfg/@registry.env
- No functional changes, environments register correctly via new system

Fixes #172
@TATP-233
TATP-233 merged commit c49e32d into main Apr 9, 2026
5 checks passed
@TATP-233
TATP-233 deleted the fix/issue-172-remove-task-registry branch April 9, 2026 16:07
TATP-233 added a commit that referenced this pull request May 4, 2026
…stry

cleanup: remove legacy TaskRegistry
TATP-233 added a commit that referenced this pull request May 30, 2026
…stry

cleanup: remove legacy TaskRegistry
TATP-233 added a commit that referenced this pull request Sep 4, 2026
…stry

cleanup: remove legacy TaskRegistry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Work: 清理遗留 TaskRegistry — 消除 registry 系统重复

1 participant