Reverts #95383 and implements a preference system for the menu bar#324
Reverts #95383 and implements a preference system for the menu bar#324flleeppyy wants to merge 2 commits into
Conversation
…ce system for it
XeonMations
left a comment
There was a problem hiding this comment.
Please make sure to modularize this PR.
it's modularized enough for TGUI. its just reverts the PR. i cannot modularize the skin file or the nova config file |
|
it is a reversion meaning its still the same code from before. its no different than not accepting specific changes from upstream because it would break something. I modularized the additional code and removals that were NOT related to my git revert. |
|
thisll have to be rewritten once the next nova upstream PR is gotten, due to tgstation/tgstation#96720 touching verbs to an incredible amount, so im keeping this on the TM until that happens |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~14 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the Oculis Station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
About The Pull Request
Title.
Reverts tgstation/tgstation#95383 and implements a preference system for the menu bar in place of it.
Also removes some nova relay stuff, we already have our own relay stuff.
Why it's Good for the Game
original PR maker is stupid for doing this without making it a preference. how it got approved and merged upstream is byond me.
Proof of Testing
Screenshots/Videos
Changelog
🆑
add: The menubar is back.
add: The menubar is now toggleable via preferences
/:cl: