Skip to content

Reverts #95383 and implements a preference system for the menu bar#324

Open
flleeppyy wants to merge 2 commits into
Monkestation:masterfrom
flleeppyy:titlebar-thing-and-revert
Open

Reverts #95383 and implements a preference system for the menu bar#324
flleeppyy wants to merge 2 commits into
Monkestation:masterfrom
flleeppyy:titlebar-thing-and-revert

Conversation

@flleeppyy

@flleeppyy flleeppyy commented Jun 29, 2026

Copy link
Copy Markdown
Member

About The Pull Request

Title.
Reverts tgstation/tgstation#95383 and implements a preference system for the menu bar in place of it.

Also removes some nova relay stuff, we already have our own relay stuff.

Why it's Good for the Game

original PR maker is stupid for doing this without making it a preference. how it got approved and merged upstream is byond me.

Proof of Testing

Screenshots/Videos image image

Changelog

🆑
add: The menubar is back.
add: The menubar is now toggleable via preferences
/:cl:

@XeonMations XeonMations left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to modularize this PR.

@flleeppyy

Copy link
Copy Markdown
Member Author

Please make sure to modularize this PR.

it's modularized enough for TGUI. its just reverts the PR. i cannot modularize the skin file or the nova config file

@flleeppyy

flleeppyy commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

it is a reversion meaning its still the same code from before. its no different than not accepting specific changes from upstream because it would break something. I modularized the additional code and removals that were NOT related to my git revert.

@XeonMations

Copy link
Copy Markdown
Collaborator

thisll have to be rewritten once the next nova upstream PR is gotten, due to tgstation/tgstation#96720 touching verbs to an incredible amount, so im keeping this on the TM until that happens

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~14 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the Oculis Station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself.

@github-actions github-actions Bot added the Stale label Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants