Skip to content

Move unGLOB'd globals to GLOB#294

Open
flleeppyy wants to merge 6 commits into
Monkestation:masterfrom
flleeppyy:globals-shit
Open

Move unGLOB'd globals to GLOB#294
flleeppyy wants to merge 6 commits into
Monkestation:masterfrom
flleeppyy:globals-shit

Conversation

@flleeppyy

@flleeppyy flleeppyy commented May 9, 2026

Copy link
Copy Markdown
Member

About The Pull Request

Code cleanup basically. Also refactors some for loops because holy fuck look at this

/mob/living/carbon/human/proc/check_head_coverage()

    var/list/body_parts = list(head, wear_mask, wear_suit, w_uniform)
    for(var/bp in body_parts)
        if(!bp)    continue
        if(bp && istype(bp ,/obj/item/clothing))
            var/obj/item/clothing/C = bp
            if(C.body_parts_covered & HEAD)
                return 1
    return 0

compared to

/mob/living/carbon/human/proc/check_head_coverage()
    var/list/body_parts = list(head, wear_mask, wear_suit, w_uniform)
    for(var/obj/item/clothing/bp in body_parts)
        return (bp.body_parts_covered & HEAD)
    return FALSE

SOOO much nicer yes?

Testing

Changelog

🆑
code: Move unGLOB'd globals to GLOB
/:cl:

@ChiefMonkengineer

ChiefMonkengineer commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Test merge deployment history:

Test Merge Deployed @ 05/29/2026 00:00:10 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 373b667
Pull Request: bc228b5
Server: d5e497990292b255dc6846b3e120862cbec5a01f

Test Merge Updated @ 06/05/2026 16:02:03 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: f700901
Pull Request: bc228b5
Server: 86213466db2ba01a7d9f9941c024b633d948260b

Test Merge Updated @ 06/05/2026 22:45:04 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: f700901
Pull Request: bc228b5
Server: 011217c94cc50cede676e54ce62cfe7803e466c3

Test Merge Updated @ 06/06/2026 19:37:17 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: f700901
Pull Request: bc228b5
Server: 158ae4e157c0e1b125c8606ea38ee1d946e56ddd

Test Merge Updated @ 06/06/2026 20:31:02 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: f700901
Pull Request: bc228b5
Server: 011217c94cc50cede676e54ce62cfe7803e466c3

Test Merge Updated @ 06/07/2026 17:54:18 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: f700901
Pull Request: bc228b5
Server: 389a080c4a69bc950d2b86a97d76528cdfd696fc

Test Merge Updated @ 06/07/2026 19:45:39 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: f700901
Pull Request: bc228b5
Server: dd25907d4d0b2407742d156e46ba98634a2ecf78

Test Merge Updated @ 06/19/2026 16:19:23 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: b865453
Pull Request: bc228b5
Server: a3cd7453c1e684349f16f320b915bc6272cdb932

Test Merge Updated @ 06/21/2026 20:14:25 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 58486fa
Pull Request: bc228b5
Server: dbf6ab46276ae926e49eb57b91caa73ba838d633

Test Merge Removed @ 06/22/2026 02:19:05 +00:00:
Server Instance

Monkeris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants