Fix GTFS-RT location inheritance from static feeds - #1811
Open
mackenziereading19 wants to merge 1 commit into
Open
Fix GTFS-RT location inheritance from static feeds#1811mackenziereading19 wants to merge 1 commit into
mackenziereading19 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes GTFS-RT feeds remaining locationless when they are imported after a referenced static GTFS feed already has location metadata.
During catalogue population, once
static_referencevalues are resolved, a GTFS-RT feed with no location metadata of its own now inherits the locations already attached to its matched static GTFS feed(s).Existing GTFS-RT locations are preserved. If multiple static feeds are referenced, their locations are combined and deduplicated by location ID.
This addresses MobilityData/mobility-database-catalogs#1567, where recently imported STM and Metra GTFS-RT feeds had valid static feed references but empty
locations.Tests
Added regression coverage for:
Local verification:
api/tests/integration/populate_tests/test_populate.py: 20 passed;functions-python/reverse_geolocation/tests/test_reverse_geolocation_processor.py: 19 passed.The reverse-geolocation suite was run using the repository's standard
function-python-setup.shshared/test-shared symlink setup.