Answer an array of MEOS values as the classes they are - #24
Merged
estebanzimanyi merged 1 commit intoSep 2, 2026
Merged
Conversation
MEOS returns many values two ways: an array of pointers (`Temporal **`, `TInstant **`) and an array of the values themselves, walked at the struct's own stride (`Span *`, `TBox *`, `STBox *`). Both reach the wrapper as an array of pointers, so both wrap element by element into the class each value's own header names, and the object layer answers `Span?[]`, `STBox?[]`, `Temporal?[]` where it answered nothing before. That is 29 more methods: `SpanSet.Spans`, `STBox.QuadSplit`, `Temporal.Instants`, the `bins` and `splitNSpans` families, 607 of the model's methods against 578. Three tests read them: the spans of a float span set come back as `FloatSpan` printing `[8, 10]` and `[11, 12]`, the four quadrants of an STBox come back as boxes, and the instants of a temporal float sequence come back as `TFloatInst`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MEOS returns many values two ways: an array of pointers (
Temporal **,TInstant **) and an array of the values themselves, walked at the struct'sown stride (
Span *,TBox *,STBox *). Both reach the wrapper as an arrayof pointers, so both wrap element by element into the class each value's own
header names, and the object layer answers
Span?[],STBox?[],Temporal?[]where it answered nothing before. That is 29 more methods:SpanSet.Spans,STBox.QuadSplit,Temporal.Instants, thebinsandsplitNSpansfamilies, 607 of the model's methods against 578.Three tests read them: the spans of a float span set come back as
FloatSpanprinting
[8, 10]and[11, 12], the four quadrants of an STBox come back asboxes, and the instants of a temporal float sequence come back as
TFloatInst.