Implement short-term roadmap goals

[MnemOnicE]

Implemented the remaining tasks on the short-term roadmap:

• Added a feedback: String field to GameState and a "SYSTEM LOG" widget to main.rs to display action feedback.
• Completed the mock serial fallback logic in serial_daemon.rs by adding mock AP regeneration feedback.
• Created tests/integration_tests.rs to test player movement, action points, and pickups logic.
• Refactored project to lib+bin to support integration testing.
• Updated ROADMAP.md checkboxes.

---

PR created automatically by Jules for task 14281858340561211043 started by @MnemOnicE

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Overview

This PR completes the short-term roadmap for the grid crawler project by introducing a feedback system for player actions, finalizing mock hardware fallback behavior, and establishing integration testing infrastructure.

Project Architecture Refactoring

The project structure was refactored from a single-binary layout to a lib+bin architecture. This separation enables code reuse and makes integration testing possible:

• Cargo.toml: Added explicit [lib] target pointing to src/lib.rs and [[bin]] target for the grid_crawler_wsl binary
• src/lib.rs: Created as the library entry point, publicly exporting three core modules: net, serial_daemon, and state
• src/main.rs: Updated to import modules from the crate using qualified paths (e.g., grid_crawler_wsl::serial_daemon::init_hardware_bridge) instead of local module declarations

This allows the game logic in state, serial_daemon, and net modules to be tested independently via integration tests.

HUD Feedback System

The game now displays action feedback to players through a new "SYSTEM LOG" widget:

• src/state.rs: Added a public feedback: String field to GameState that captures the outcome of player actions
• Feedback Messages: Updated core game functions to populate feedback:
  • move_player(): Reports movement success, out-of-bounds errors, blocked paths, and AP shortages
  • fire_at_direction(): Provides feedback for successful shots, AP depletion, destroyed enemies, cleared obstacles, and misses
  • consume_tile_effect(): Logs the effect of collected tiles (health restoration, smoke charges, AP generation, mine damage, wreck armor reduction)
  • regenerate_map(): Confirms map regeneration
• src/main.rs: Integrated a new "SYSTEM LOG" panel in the combat UI that renders feedback text in light-green styling, making action outcomes immediately visible to players

Mock Hardware Fallback Enhancement

• src/serial_daemon.rs: The fallback mock serial interface now updates the feedback field when simulating AP regeneration, displaying "Hardware mock: Regenerated 1 AP" to reflect hardware behavior even when real serial hardware is unavailable

Integration Tests

• tests/integration_tests.rs: Added comprehensive integration tests covering core mechanics:
  • Movement & Tile Interaction Test: Validates walking onto a Health tile (checking AP cost, health gain, and tile state changes), firing a weapon (AP deduction, map state update), and confirming AP prevents repeated actions
  • Obstacle & Mine Navigation Test: Confirms movement is blocked by walls without consuming resources, allows movement through empty space with proper AP deduction, and validates damage when stepping on mines

These tests verify that the public API of the game logic works correctly by constructing GameState directly and calling public methods—a key benefit of the lib+bin architecture.

Documentation

• ROADMAP.md: Marked three short-term goals as completed:
  • Mock serial fallback for hardware development
  • In-game HUD and action feedback
  • Integration tests for movement, action points, and pickups

Walkthrough

Adds a feedback: String field to GameState that is populated by all game actions (move_player, fire_at_direction, consume_tile_effect, regenerate_map, and the serial mock). src/lib.rs publicly exposes the three modules; Cargo.toml gains explicit [lib] and [[bin]] targets. src/main.rs adopts crate-qualified paths and renders the feedback string in a new SYSTEM LOG TUI panel. Two integration tests validate multi-step player action sequences.

Changes

Feedback System and HUD

Layer / File(s)	Summary
Crate targets and public module declarations Cargo.toml, src/lib.rs	Adds explicit [lib] and [[bin]] Cargo targets and declares net, serial_daemon, and state as public crate-root modules.
GameState.feedback field and action feedback writes src/state.rs	Adds pub feedback: String to GameState and sets outcome messages in initialize_state, regenerate_map, move_player, fire_at_direction, and consume_tile_effect.
Serial mock feedback write src/serial_daemon.rs	AP regeneration in the serial fallback simulator writes "Hardware mock: Regenerated 1 AP" to lock.feedback.
Crate-qualified wiring and SYSTEM LOG HUD rendering src/main.rs	Removes local mod declarations, uses grid_crawler_wsl::-qualified startup calls, adds a SYSTEM LOG layout slot, and renders state.feedback in that panel with light-green styling.
Integration tests, unit test updates, and ROADMAP tests/integration_tests.rs, src/state.rs, ROADMAP.md	Adds two integration tests for move/pickup/fire and move/wall/mine sequences; updates existing unit test GameState literals with the feedback field; marks three ROADMAP items done.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• MnemOnicE/grid_crawler_wsl#1: Overlaps directly on src/state.rs tile effect handling (consume_tile_effect, movement/firing) and src/main.rs viewport logic that this PR extends with feedback messages.

Poem

🎮 Drop the feedback field, the HUD gon' flex,
SYSTEM LOG lit up in light green text —
move_player spits bars, "blocked by a wall,"
fire_at_direction — enemy fall, obstacle cleared, or miss call,
Mock daemon whispers "Regenerated 1 AP" for the fans,
Integration tests confirm the whole game plan —
Cargo got targets, lib exports stand! 🔥

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 78.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main objective: implementing short-term roadmap goals including HUD feedback, mock serial logic, integration tests, and project restructuring.
Description check	✅ Passed	The description provides clear, specific details about implemented changes across multiple areas (feedback system, mock serial, integration tests, restructuring, documentation) and directly relates to the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/roadmap-tasks-14281858340561211043

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request restructures the project into a library and binary, introduces integration tests, and adds a 'SYSTEM LOG' UI widget to display real-time game feedback. Feedback messages are now tracked in the game state and updated during movement, combat, and item pickups. The review feedback highlights three key issues: the mock serial daemon constantly overwrites the system log even when AP is already at maximum, fire_at_direction can enter an infinite loop if both direction deltas are zero, and move_player allows zero-delta moves that waste action points. Corrective code suggestions are provided for all three issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The mock serial daemon background thread runs every second and sets lock.feedback = "Hardware mock: Regenerated 1 AP". This happens even if the player's AP is already at the maximum of 12 (so no AP is actually regenerated). This constantly overwrites any other active feedback in the system log (like "Moved successfully", "Target destroyed!", etc.) with a misleading message, making the system log feature almost useless when using the mock fallback.

                    if lock.stats.ap < 12 {
                        lock.stats.ap += 1;
                        lock.feedback = "Hardware mock: Regenerated 1 AP".to_string();
                    }

[gemini-code-assist]

If dx and dy are both 0, fire_at_direction will enter an infinite loop because cx and cy will never change, causing the application to hang. Adding a guard to prevent zero-delta firing avoids this critical failure.

    if dx == 0 && dy == 0 {
        return false;
    }
    let idx = state.player_idx;
    if state.stats.ap < 2 {

[gemini-code-assist]

If dx and dy are both 0, move_player will still execute, decrementing the player's AP by 1 and performing a redundant self-assignment of the player tile without actually moving. Adding a guard to prevent zero-delta moves avoids wasting AP.

    if dx == 0 && dy == 0 {
        return false;
    }
    let nx = x as isize + dx;
    let ny = y as isize + dy;