Repository navigation
fix: address referral security, notification errors, and cache/search persistence - #1169
Merged
Merged
Conversation
|
@eyooTech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several backend reliability, security, and consistency issues:
Changes
Referral code security (Referral codes are generated with Math.random: guessable codes enable referral abuse #1091)
Math.random()-based referral code generation with cryptographically secure random generation.Notification authorization errors (NotificationsService throws bare Error: unauthorized markAsRead and delete return 500 instead of 403 #1092)
Errorthrows with the appropriate NestJS forbidden exception.markAsReadanddeleteoperations now correctly return HTTP 403 Forbidden instead of HTTP 500 Internal Server Error.Cache monitoring persistence (Cache monitoring counters are process-local: hit/miss metrics reset to zero on every restart #1093)
Search history persistence (Search history is held in a process-local Map: history vanishes on restart and diverges across instances #1094)
Mapused for search history with persistent storage.Issues
Closes #1091
Closes #1092
Closes #1093
Closes #1094