Repository navigation
feat: async context manager support for Python SDK connection cleanup - #915
Closed
laurentketterle-hub wants to merge 1 commit into
Closed
laurentketterle-hub wants to merge 1 commit into
laurentketterle-hub wants to merge 1 commit into
Conversation
- Adds __aenter__/__aexit__ for async context manager support - Adds __enter__/__exit__ for sync context manager support - Ensures proper connection cleanup on context exit - Skips reconnect if already connected - Adds comprehensive tests for both sync and async paths - Adds Python SDK CI workflow Closes MetroLogic#796
Author
|
Automated CI refresh: no activity for 7 days. Closing and reopening to trigger CI re-run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds async context manager support (
__aenter__/__aexit__) to the Python SDK for proper connection cleanup.Changes
__aenter__/__aexit__: Async context manager methods that ensure:__enter__/__exit__: Sync context manager methods for non-async usageTests: Comprehensive test coverage for:
CI: Python SDK CI workflow with pytest-asyncio across Python 3.9-3.12
Usage
Closes #796