Skip to content

3D chunking for chemistry full-domain mode #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pierre Siddall (Pierre-siddall) merged 8 commits into from
Sep 24, 2026
Merged

3D chunking for chemistry full-domain mode #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
08dfc64
3D chunking for chemistry full-domain mode
mn416 Jun 4, 2026
74b5407
Add myself to contributors files
mn416 Jul 6, 2026
1a31d86
Apply umdp3_fixer
mn416 Jul 6, 2026
783ba21
Drop apostrophe in comment that generates a warning
mn416 Jul 6, 2026
ebda85b
Suggestions from Joe W. for chemistry 3D chunking
mn416 Sep 21, 2026
1304838
Emit 3D chunk size if modified
mn416 Sep 22, 2026
c00e474
Merge branch 'main' into mn416-3d-chunking
Pierre-siddall Sep 23, 2026
c78ab29
Style tweak in `ukca_setup_mod.F90` for 3D chunking
mn416 Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@
| yaswant | Yaswant Pradhan | Met Office | 2026-07-17 |
| RobWatersMet | Rob Waters | NCAS & University of Cambridge | 2026-07-06 |
| alanjhewitt | Alan J Hewitt | Met Office | 2026-07-12 |
| mn416 | Matthew Naylor | University of Cambridge | 2026-07-24 |
| t00sa | Sam Clarke-Green | Met Office | 2026-09-10 |
1 change: 1 addition & 0 deletions CONTRIBUTORS_LIST.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Florent Malavelle Met Office
Andy Malcolm Met Office
Cameron McErlich University of Canterbury
Jane Mulcahy Met Office
Matthew Naylor University of Cambridge
Charlotte Norris Met Office
Amy Peace Met Office
Leighton Regayre Met Office and University of Leeds
Expand Down
7 changes: 7 additions & 0 deletions src/control/core/interface/ukca_config_specification_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ MODULE ukca_config_specification_mod
! (2-50, 3 recommended)
INTEGER :: ukca_chem_seg_size ! Grid points per segment for the
! column-based chemical solver
INTEGER :: ukca_chem_full_chunk_size(3) ! Grid points per 3D chunk in the
! full-domain-based chemical solver
REAL :: max_z_for_offline_chem ! Maximum height at which to integrate
! chemistry with the explicit B-E
! Offline Oxidants scheme
Expand Down Expand Up @@ -875,6 +877,7 @@ SUBROUTINE init_ukca_configuration()
ukca_config%i_ukca_quasinewton_start = imdi
ukca_config%i_ukca_quasinewton_end = imdi
ukca_config%ukca_chem_seg_size = imdi
ukca_config%ukca_chem_full_chunk_size(:) = [-1, -1, -1]
ukca_config%max_z_for_offline_chem = rmdi
ukca_config%nlev_above_trop_o3_env = imdi
ukca_config%nlev_ch4_stratloss = imdi
Expand Down Expand Up @@ -1091,6 +1094,7 @@ SUBROUTINE ukca_get_config( &
dts0, nit, &
i_ukca_quasinewton_start, i_ukca_quasinewton_end, &
ukca_chem_seg_size, &
ukca_chem_full_chunk_size, &
nlev_above_trop_o3_env, &
nlev_ch4_stratloss, &
i_ukca_topboundary, &
Expand Down Expand Up @@ -1285,6 +1289,7 @@ SUBROUTINE ukca_get_config( &
INTEGER, OPTIONAL, INTENT(OUT) :: i_ukca_quasinewton_start
INTEGER, OPTIONAL, INTENT(OUT) :: i_ukca_quasinewton_end
INTEGER, OPTIONAL, INTENT(OUT) :: ukca_chem_seg_size
INTEGER, OPTIONAL, INTENT(OUT) :: ukca_chem_full_chunk_size(3)
INTEGER, OPTIONAL, INTENT(OUT) :: nlev_above_trop_o3_env
INTEGER, OPTIONAL, INTENT(OUT) :: nlev_ch4_stratloss
INTEGER, OPTIONAL, INTENT(OUT) :: i_ukca_topboundary
Expand Down Expand Up @@ -1573,6 +1578,8 @@ SUBROUTINE ukca_get_config( &
i_ukca_quasinewton_end = ukca_config%i_ukca_quasinewton_end
IF (PRESENT(ukca_chem_seg_size)) &
ukca_chem_seg_size = ukca_config%ukca_chem_seg_size
IF (PRESENT(ukca_chem_full_chunk_size)) &
ukca_chem_full_chunk_size = ukca_config%ukca_chem_full_chunk_size
IF (PRESENT(max_z_for_offline_chem)) &
max_z_for_offline_chem = ukca_config%max_z_for_offline_chem
IF (PRESENT(nlev_above_trop_o3_env)) &
Expand Down
28 changes: 27 additions & 1 deletion src/control/core/top_level/ukca_main1-ukca_main1.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,9 @@ SUBROUTINE ukca_main1(error_code_ptr, timestep_number, current_time, &
TYPE(autotune_type), ALLOCATABLE, SAVE :: autotune_state
#endif

! Full-domain chunk size in each dimension
INTEGER :: full_chunk_x, full_chunk_y, full_chunk_z

CHARACTER(LEN=*), PARAMETER :: RoutineName='UKCA_MAIN1'

!- End of header
Expand All @@ -604,7 +607,29 @@ SUBROUTINE ukca_main1(error_code_ptr, timestep_number, current_time, &
theta_field_size = row_length * rows
tot_n_pnts = theta_field_size * model_levels
IF (ukca_config%l_ukca_asad_full) THEN
n_pnts = tot_n_pnts
! Determine chunk size for full-domain 3D chunking
full_chunk_x = ukca_config%ukca_chem_full_chunk_size(1)
full_chunk_y = ukca_config%ukca_chem_full_chunk_size(2)
full_chunk_z = ukca_config%ukca_chem_full_chunk_size(3)
IF (full_chunk_x <= 0 .OR. full_chunk_x > row_length) THEN
WRITE(umMessage,'(A,I0)') &
'Setting chemistry chunk row length to ', row_length
CALL umPrint(umMessage,src=RoutineName)
full_chunk_x = row_length
END IF
IF (full_chunk_y <= 0 .OR. full_chunk_y > rows) THEN
WRITE(umMessage,'(A,I0)') &
'Setting chemistry rows-per-chunk to ', rows
CALL umPrint(umMessage,src=RoutineName)
full_chunk_y = rows
END IF
IF (full_chunk_z <= 0 .OR. full_chunk_z > model_levels) THEN
WRITE(umMessage,'(A,I0)') &
'Setting chemistry levels-per-chunk to ', model_levels
CALL umPrint(umMessage,src=RoutineName)
full_chunk_z = model_levels

@theabro Luke Abraham (theabro) Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest printing a warning here within each IF to say that the value of the chunk has been reset to row_length / rows / model_levels, otherwise the code is changing something without the user being informed. The metadata for this namelist entry does say that this will be happening, but I'd also put a warning message here that it's been done

@mn416 mn416 Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luke Abraham (@theabro), done in commit 1304838.

END IF
n_pnts = full_chunk_x * full_chunk_y * full_chunk_z
ELSE IF (ukca_config%l_ukca_asad_columns) THEN
n_pnts = ukca_config%ukca_chem_seg_size
ELSE
Expand Down Expand Up @@ -2340,6 +2365,7 @@ SUBROUTINE ukca_main1(error_code_ptr, timestep_number, current_time, &
CALL ukca_chemistry_ctl_full( &
row_length, rows, model_levels, &
theta_field_size, tot_n_pnts, &
full_chunk_x, full_chunk_y, full_chunk_z, &
n_chem_tracers+n_aero_tracers, &
istore_h2so4, &
p_theta_levels, &
Expand Down
10 changes: 10 additions & 0 deletions src/control/core/top_level/ukca_setup_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ SUBROUTINE ukca_setup(error_code, &
i_ukca_quasinewton_start, &
i_ukca_quasinewton_end, &
ukca_chem_seg_size, &
ukca_chem_full_chunk_size, &
nlev_above_trop_o3_env, &
nlev_ch4_stratloss, &
i_ukca_topboundary, &
Expand Down Expand Up @@ -414,6 +415,7 @@ SUBROUTINE ukca_setup(error_code, &
INTEGER, OPTIONAL, INTENT(IN) :: i_ukca_quasinewton_start
INTEGER, OPTIONAL, INTENT(IN) :: i_ukca_quasinewton_end
INTEGER, OPTIONAL, INTENT(IN) :: ukca_chem_seg_size
INTEGER, OPTIONAL, INTENT(IN) :: ukca_chem_full_chunk_size(3)
INTEGER, OPTIONAL, INTENT(IN) :: nlev_above_trop_o3_env
INTEGER, OPTIONAL, INTENT(IN) :: nlev_ch4_stratloss
INTEGER, OPTIONAL, INTENT(IN) :: i_ukca_topboundary
Expand Down Expand Up @@ -838,6 +840,14 @@ SUBROUTINE ukca_setup(error_code, &

END IF

! Full-domain-based run configuration
IF (ukca_config%l_ukca_asad_full) THEN
ukca_config%ukca_chem_full_chunk_size(:) = [-1, -1, -1]
IF (PRESENT(ukca_chem_full_chunk_size)) THEN
ukca_config%ukca_chem_full_chunk_size(:) = ukca_chem_full_chunk_size(:)
END IF
END IF
Comment on lines +844 to +849

@Pierre-siddall Pierre Siddall (Pierre-siddall) Sep 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an END IF and THEN statement could be added here to keep styling consistent that would be great.

Suggested change
IF (ukca_config%l_ukca_asad_full) THEN
ukca_config%ukca_chem_full_chunk_size(:) = [-1, -1, -1]
IF (PRESENT(ukca_chem_full_chunk_size)) &
ukca_config%ukca_chem_full_chunk_size(:) = ukca_chem_full_chunk_size(:)
END IF
IF (ukca_config%l_ukca_asad_full) THEN
ukca_config%ukca_chem_full_chunk_size(:) = [-1, -1, -1]
IF (PRESENT(ukca_chem_full_chunk_size)) THEN &
ukca_config%ukca_chem_full_chunk_size(:) = ukca_chem_full_chunk_size(:)
END IF
END IF

@mn416 mn416 Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre Siddall (@Pierre-siddall), done in commit c78ab29.

@Pierre-siddall Pierre Siddall (Pierre-siddall) Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre Siddall (Pierre Siddall (@Pierre-siddall)), done in commit c78ab29.

No problem mn416 and thanks for responding to the feedback quickly.


! Configuration specific to explicit B-E Offline Oxidants scheme
IF (ukca_config%i_ukca_chem == i_ukca_chem_offline_be) THEN
IF (PRESENT(max_z_for_offline_chem)) &
Expand Down
Loading
Loading