Repository navigation
Improve cmake targets for code linters - #192
Open
Matt Shin (matthewrmshin) wants to merge 5 commits into
Open
Matt Shin (matthewrmshin) wants to merge 5 commits into
Matt Shin (matthewrmshin) wants to merge 5 commits into
Conversation
Modify cpplint target to use `cpplint` from the environment. ~Remove `cpplint.py` from source tree.~ cpplint 2.0.2 happiness: - Fix build/include_what_you_use - Update filter categories.
Collaborator
|
Does this work have an associated issue somewhere like mo-bundle? Does it have dependencies? It is all looking good though! Very happy to make the changes. |
Collaborator
Author
|
Associated mo-bundle PR is https://github.com/MetOffice/mo-bundle/pull/1098 to take full advantage. There is no inter-dependency. |
Collaborator
|
Can we take this out of draft yet? I think maybe we should remove the existing tools/cpplint.py as part of this change and use the central one in the CI as well as part of this change if possible, just for completeness? |
Matt Shin (matthewrmshin)
marked this pull request as ready for review
July 22, 2026 12:01
Matt Shin (matthewrmshin)
requested a review
from Toby Searle (twsearle)
as a code owner
July 22, 2026 12:01
Toby Searle (twsearle)
requested changes
Jul 22, 2026
Toby Searle (twsearle)
left a comment
Toby Searle (twsearle)
left a comment
Collaborator
There was a problem hiding this comment.
All looking good! Please can you git rm tools/cpplint.py and see if the CI still runs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify cpplint target to use
cpplintfrom the environment. ~Removecpplint.pyfrom source tree.cpplint 2.0.2 happiness:
Issue(s) addressed
Resolves #<issue_number>
Impact
We can use more standard cpp linting tools.
Checklist