Repository navigation
Sip phillips mode1 mode2 breakup - #25
Open
Paul J. Connolly (maul1609) wants to merge 3 commits into
Open
Paul J. Connolly (maul1609) wants to merge 3 commits into
Paul J. Connolly (maul1609) wants to merge 3 commits into
Conversation
Add three secondary ice production (SIP) processes following Phillips et al. (2017, 2018), with the collision integrals evaluated numerically over the gamma size distributions (Sun et al., 2025, ACP 25, 18549-18569): sip_phillips_mode1 fragmentation of freezing raindrops (Mode 1) sip_phillips_mode2 fragmentation in rain-ice collisions (Mode 2) sip_phillips_breakup ice-ice collisional breakup Each is switched on with l_sip_phillips_mode1, l_sip_phillips_mode2 or l_sip_phillips_breakup; all default to .false., so existing configurations are unchanged. They are alternatives to l_sip_dropletshatter and l_sip_icebreakup, and setting both members of a pair stops the model with an error. New process rates pimo1, pimo2 and piicbi/s/g, and diagnostics nimo1, nimo2 and niicb. Breakup donor mass is limited by limit_cb_donor after the standard positivity checks. sip_numerics provides fixed-order Gauss-Legendre quadrature in one and two dimensions and the inverse regularised incomplete gamma function used to truncate the size distributions. Developed at the University of Manchester under the Horizon Europe project CERTAINTY (grant agreement 101137680).
Move gamma_p and inverse_gamma_p into special, alongside GammaFunc, and the Gauss-Legendre quadrature into ice_multiplication, its only user. Remove sip_numerics.F90 and restore the makefile. No change to results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add Phillips et al. secondary ice production schemes (Mode 1, Mode 2, collisional breakup)
Sci/Tech Reviewer: paulfield2024
Code Reviewer:
Adds three SIP processes following Phillips et al. (2017, 2018), with collision integrals evaluated numerically over the gamma size distributions, as used in Sun et al. (2025, ACP, doi:10.5194/acp-25-18549-2025):
sip_phillips_mode1: freezing-drop fragmentation (Mode 1)sip_phillips_mode2: rain–ice splashing (Mode 2)sip_phillips_breakup: ice–ice collisional breakupSwitched on with
l_sip_phillips_mode1,l_sip_phillips_mode2andl_sip_phillips_breakup, all default.false., so existing configurations are unchanged. They are alternatives tol_sip_dropletshatterandl_sip_icebreakup; setting both of a pair stops with an error. Adds diagnosticsnimo1,nimo2andniicb. No new files: the quadrature is inice_multiplicationand the inverse incomplete gamma function inspecial.Funded by Horizon Europe CERTAINTY (grant 101137680).
Code Quality Checklist
Testing
Compiles with gfortran 13; no new fortitude violations. With the new switches off, no existing process or list changes value, so results should be unchanged. Standalone kernel tests reproduce the rates of the code used in Sun et al. to within 1e-5 relative (the difference is from using double-precision 273.15 K). Rose stem not run.
Security Considerations
Performance Impact
No cost when switched off. When on, the collision integrals add cost per grid box; timings to follow.
AI Assistance and Attribution
Documentation
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review