Repository navigation
Fix hm snow positivity - #24
Open
Paul J. Connolly (maul1609) wants to merge 3 commits into
Open
Paul J. Connolly (maul1609) wants to merge 3 commits into
Paul J. Connolly (maul1609) wants to merge 3 commits into
Conversation
hallet_mossop removes rimed mass from snow (procs(snow%i_1m, i_ihal) = -dmass_s), but i_ihal was passed to ensure_positive for snow in the non-scalable list. Non-scalable processes are never limited, so when the other snow sinks are small, rime splintering could take snow mass below zero. Move i_ihal to the scalable list for snow. ensure_positive rescales all species of a process together, so the ice source from splintering is reduced consistently with the snow sink. Results change only in grid boxes where the snow positivity limiter is active.
github-actions
Bot
added
the
cla-required
github-actions
Bot
added
cla-signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix snow positivity limiting for Hallett–Mossop
Sci/Tech Reviewer: paulfield2024
Code Reviewer:
Hallett–Mossop removes snow mass but was in the non-scalable list in the snow
ensure_positivecall, so it could make snow negative. This movesi_ihalto the scalable list. Also adds me toCONTRIBUTORS.md.Code Quality Checklist
Testing
Compiles with gfortran. Rose stem not run; KGO changes expected where the snow limiter is active.
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review