Skip to content

OSS RE: enable SSLKEYLOGFILE #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lf- wants to merge 1 commit into
base: mercury-head-next
Choose a base branch
from
Open

OSS RE: enable SSLKEYLOGFILE #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion remote_execution/oss/re_grpc/src/pool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ impl ChannelConfig {
}

async fn create_tls_config(opts: &Buck2OssReConfiguration) -> anyhow::Result<ClientTlsConfig> {
let config = ClientTlsConfig::new().with_enabled_roots();
// use_key_log(): store the session keys to a file when SSLKEYLOGFILE
// is set in env, to allow decrypting PCAP files for debugging. See:
// - https://www.ietf.org/archive/id/draft-thomson-tls-keylogfile-00.html
// - https://wiki.wireshark.org/TLS
let config = ClientTlsConfig::new().with_enabled_roots().use_key_log();

let config = match opts.tls_ca_certs.as_ref() {
Some(tls_ca_certs) => {
Expand Down
Loading