Skip to content

Build with arm versions #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattfarina merged 3 commits into from
Aug 23, 2016
Merged

Build with arm versions #528

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a59492
build with arm versions
franciscocpg Jul 27, 2016
c6ef71b
Include arm64(armv8) for linux
franciscocpg Jul 28, 2016
9f0d3a9
Remove duplicated line
franciscocpg Jul 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ bootstrap-dist:
build-all:
gox -verbose \
-ldflags "-X main.version=${VERSION}" \
-ldflags "-X main.version=${VERSION}" \

@dnephin dnephin Jul 28, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this line is duplicated?

-os="linux darwin windows " \
-arch="amd64 386" \
-arch="amd64 386 armv5 armv6 armv7 arm64" \

@dnephin dnephin Jul 28, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it out and I don't think armv{5,6,7} are valid. It just ignores the arch's it doesn't know about.

I believe only arm and arm64 are valid.

@franciscocpg franciscocpg Jul 28, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained in the first conversation of this PR you must use a gox fork to work.

@dnephin dnephin Jul 28, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I built with just arm and it's working fine on armv7.

@franciscocpg franciscocpg Jul 28, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but as stated here

In cross compilation situations, it is recommended that you always set an appropriate GOARM value along with GOARCH.

-osarch="!darwin/arm64" \
-output="dist/{{.OS}}-{{.Arch}}/{{.Dir}}" .

dist: build-all
Expand Down