Skip to content

Derive the class name in CurvesAsSubmobjects error messages #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cqxswbc2 wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −2
Open

Derive the class name in CurvesAsSubmobjects error messages #4995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions manim/mobject/types/vectorized_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2856,8 +2856,9 @@ def point_from_proportion(self, alpha: float) -> Point3D:
def _throw_error_if_no_submobjects(self):
if len(self.submobjects) == 0:
caller_name = sys._getframe(1).f_code.co_name
cls = type(self).__name__
raise Exception(
f"Cannot call CurvesAsSubmobjects. {caller_name} for a CurvesAsSubmobject with no submobjects"
f"Cannot call {cls}.{caller_name} for a {cls} with no submobjects"
)

def _get_submobjects_with_points(self):
Expand All @@ -2866,8 +2867,9 @@ def _get_submobjects_with_points(self):
)
if len(submobjs_with_pts) == 0:
caller_name = sys._getframe(1).f_code.co_name
cls = type(self).__name__
raise Exception(
f"Cannot call CurvesAsSubmobjects. {caller_name} for a CurvesAsSubmobject whose submobjects have no points"
f"Cannot call {cls}.{caller_name} for a {cls} whose submobjects have no points"
)
return submobjs_with_pts

Expand Down
22 changes: 22 additions & 0 deletions tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,28 @@ def test_curves_as_submobjects_point_from_proportion():
np.testing.assert_array_equal(obj.point_from_proportion(0.5), np.array([3, 0, 0]))


def test_curves_as_submobjects_error_messages_use_the_actual_class_name():
class DerivedCurves(CurvesAsSubmobjects):
pass

obj = DerivedCurves(VGroup())

with pytest.raises(
Exception,
match=r"Cannot call DerivedCurves\.point_from_proportion for a "
r"DerivedCurves with no submobjects",
):
obj.point_from_proportion(0)

obj.add(VMobject())
with pytest.raises(
Exception,
match=r"Cannot call DerivedCurves\.point_from_proportion for a "
r"DerivedCurves whose submobjects have no points",
):
obj.point_from_proportion(0)


def test_vgroup_init():
"""Test the VGroup instantiation."""
VGroup()
Expand Down