Use runtime class names in CurvesAsSubmobjects errors - #4984
Open
MohammedThowfiq wants to merge 1 commit into
Open
Use runtime class names in CurvesAsSubmobjects errors#4984MohammedThowfiq wants to merge 1 commit into
MohammedThowfiq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Use the runtime class name in both CurvesAsSubmobjects empty-geometry error messages. Subclasses now name themselves instead of reporting CurvesAsSubmobjects. The messages also use the correct class spelling and remove the stray space between the class and method names.
Fixes #4983.
Motivation and Explanation: Why and how do your changes improve the library?
Adds four regression cases covering the base class and a subclass, each with no submobjects and with a point-less child. All four fail on the previous messages and pass with this change.
Links to added or changed documentation pages
Not applicable — diagnostic messages only.
Further Information and Comments
Validation on Python 3.12/macOS:
pytest tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py -o addopts='' -q— 46 passed.latexexecutable (test_scale_stroke_preserves_zero_width_on_number_plane_coordinates).The full rendering suite was not run locally.
Reviewer Checklist