Skip to content

Use runtime class names in CurvesAsSubmobjects errors - #4984

Open
MohammedThowfiq wants to merge 1 commit into
ManimCommunity:mainfrom
MohammedThowfiq:codex/dynamic-curve-error-names
Open

Use runtime class names in CurvesAsSubmobjects errors#4984
MohammedThowfiq wants to merge 1 commit into
ManimCommunity:mainfrom
MohammedThowfiq:codex/dynamic-curve-error-names

Conversation

@MohammedThowfiq

Copy link
Copy Markdown

Overview: What does this pull request change?

Use the runtime class name in both CurvesAsSubmobjects empty-geometry error messages. Subclasses now name themselves instead of reporting CurvesAsSubmobjects. The messages also use the correct class spelling and remove the stray space between the class and method names.

Fixes #4983.

Motivation and Explanation: Why and how do your changes improve the library?

Adds four regression cases covering the base class and a subclass, each with no submobjects and with a point-less child. All four fail on the previous messages and pass with this change.

Links to added or changed documentation pages

Not applicable — diagnostic messages only.

Further Information and Comments

Validation on Python 3.12/macOS:

  • pytest tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py -o addopts='' -q — 46 passed.
  • Broader vectorized_mobject directory run — 59 passed, one failure because the local environment has no latex executable (test_scale_stroke_preserves_zero_width_on_number_plane_coordinates).
  • Ruff checks and formatting passed for both changed files.

The full rendering suite was not run locally.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CurvesAsSubmobjects error messages contain hardcoded class names

1 participant