Repository navigation
docs(benchmarks): gate-971 section 8 points the embedding stall at the shared slot (#975) - #1781
Merged
Merged
Conversation
MakazhanAlpamys
added
the
ci:full
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the dated correction note promised on #975 (2026-10-04) to
benchmarks/gate-971-async-nvme-source.md, section 8.Section 8 still explained the embedding stall with the
_plan_queuesingle-member-group sentence (opening paragraph, and again in Finding 8a) and did not point at #975. Two inline notes in the record's own style (like its 2026-09-14 16:45 corrections) now say that for the embedding entry the shared large-layer slot described in #975 supersedes that explanation (embed_tokensandlm_headshare one device slot, so each step's_prime()re-copies the whole matrix host to device; fixed by #1178), and that the record's other findings, including the 0.07-0.12% materiality ruling, stand. The original sentences are left in place.Docs only: one file, 11 added lines, no code, no changelog fragment (the record is not user-facing documentation). Cyrillic check clean; pre-commit hooks pass.
Closes #975.