Tech: Refacto de l'objet LegacyControlUnit et LegacyControlResources by maximeperraultdev · Pull Request #2973 · MTES-MCT/monitorenv

maximeperraultdev · 2026-06-17T16:32:23Z

Remove Entity from Output and Input Data.
Keep legacy for legacy endpoint
Use ControlUnitEntity and ControlUnitResourceEntity instead of legacy

tristanrobert · 2026-06-17T16:32:42Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

sonarqubecloud · 2026-06-17T16:36:08Z

Quality Gate failed

Failed conditions
9.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

claire2212 · 2026-07-22T13:21:50Z

 package fr.gouv.cacem.monitorenv.domain.entities.controlUnit

-// TODO Replace this entity with `ControlUnitEntity`. It's left for `MissionEntity.units` backward compatibility.
 data class LegacyControlUnitEntity(


Il ne faut pas supprimer cette Entité?

Non elle sert encore pour les endpoint qui l'utilisait. J'ai uniquement séparé en 3 data class.
Legac

claire2212 · 2026-07-22T13:27:45Z

+            isArchived = false,
+            note = null,
+            photo = null,
+            // TODO: ???


a supprimer?

claire2212 · 2026-07-22T13:28:26Z

+            note = null,
+            photo = null,
+            // TODO: ???
+            stationId = 1,


pourquoi stationId = 1

houla oups.

claire2212 · 2026-07-22T13:34:17Z

-                controlUnits = dto.mission.controlUnits,
+                controlUnits =
+                    dto.mission.controlUnits.map {
+                        LegacyControlUnitDataOutput.fromControlUnit(


pourquoi LegacyControlUnitDataOutput ?

on laisse les legacyDataOutput et Input. Avant on avait des legacyControlUnitEntity. Ce qui posait des soucis pour les consommateurs de nos apis si on changeait l'entité.

Mais j'avoue que je pourrais les nommer autrement car il n'y en a pas d'autres...

claire2212 · 2026-07-22T13:34:34Z

-                controlUnits = mission.controlUnits,
+                controlUnits =
+                    mission.controlUnits.map {
+                        LegacyControlUnitDataOutput.fromControlUnit(


pourquoi LegacyControlUnitDataOutput ?

claire2212 · 2026-07-22T13:37:00Z

-                controlUnits = dto.mission.controlUnits,
+                controlUnits =
+                    dto.mission.controlUnits.map {
+                        LegacyControlUnitDataOutput.fromControlUnit(


même question

claire2212 · 2026-07-22T13:37:28Z

-                controlUnits = mission.controlUnits,
+                controlUnits =
+                    mission.controlUnits.map {
+                        LegacyControlUnitDataOutput.fromControlUnit(


claire2212 · 2026-07-22T13:46:22Z

-
-import type { ControlTheme } from '../domain/entities/controlThemes'
-
-export const controlThemesAPI = monitorenvPrivateApi.injectEndpoints({


bah c'était quoi ce fichier ???

un reliquat du passé je dirais.

sonarqubecloud · 2026-07-30T15:32:09Z

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

maximeperraultdev added the tech. enhancement technical enhancement label Jun 17, 2026

maximeperraultdev force-pushed the maxime/tech/legacy_control_unit branch from 8437660 to 5680ec9 Compare June 17, 2026 16:33

maximeperraultdev force-pushed the maxime/tech/legacy_control_unit branch 5 times, most recently from 8ae3aa4 to deca74b Compare July 21, 2026 07:01

maximeperraultdev requested a review from claire2212 July 21, 2026 07:03

maximeperraultdev force-pushed the maxime/tech/legacy_control_unit branch 2 times, most recently from cf0bdce to 0de958e Compare July 21, 2026 15:22

claire2212 reviewed Jul 22, 2026

View reviewed changes

maximeperraultdev force-pushed the maxime/tech/legacy_control_unit branch from 0de958e to 45811a5 Compare July 30, 2026 15:07

maximeperraultdev added 3 commits July 30, 2026 17:31

tech: move data class into packages. Add missing input/outputs

50fc2a0

tech: move data class into packages. Add missing input/outputs

ff260fd

feat: claire's review. Quick cleanup

2b8a506

maximeperraultdev force-pushed the maxime/tech/legacy_control_unit branch from ab7d396 to 2b8a506 Compare July 30, 2026 15:31


		import type { ControlTheme } from '../domain/entities/controlThemes'

		export const controlThemesAPI = monitorenvPrivateApi.injectEndpoints({

Uh oh!

Conversation

maximeperraultdev commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tristanrobert commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

sonarqubecloud Bot commented Jun 17, 2026

Quality Gate failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 30, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maximeperraultdev commented Jun 17, 2026 •

edited

Loading

tristanrobert commented Jun 17, 2026 •

edited

Loading