Repository navigation
[GrantFox Bot] Contract test_snapshots/ is .gitignore'd but still tracked, churning huge diffs on every contract PR (#234) - #284
Closed
ZacLou wants to merge 1 commit into
Conversation
…cked, churning huge diffs on every contract PR (LynxXProtocol#234) Auto-generated by GrantFox Task Executor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Closed: issue #234 is already resolved and test_snapshots/ are untracked on main. |
amankoli09
added a commit
that referenced
this pull request
Oct 20, 2026
…mat repo - Purge committed 87MB binaries (stellar, stellar-cli-*.tar.gz) and debug JSONs - Relocate STAKING_IMPLEMENTATION_REPORT.md to docs/ and create_issues.sh to scripts/tools/ - Remove tracked build artifacts (dist-crypto-test, test-results/.last-run.json) - Populate standard .editorconfig and Contributor Covenant CODE_OF_CONDUCT.md - Add safety checks in backend/tests/setup.ts & attestor.test.ts for offline Docker runtimes - Close completed issue #234 and duplicate PRs #284 & #282 - Format workspace with Prettier (0 lint/format/id errors, all test suites pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #234
此 PR 由 GrantFox Task Executor 自动生成。
原始 issue: #234
说明:
Summary
.gitignore(line 36) liststest_snapshots/, but 127 JSON files undercontracts/*/test_snapshots/**are tracked in git and have been touched across 36 commits. Git doesn't retroactively untrack files that were already committed before a matching ignore rule was added, so these files are simultaneously "meant to be ignored" and "actively kept in sync on every commit."Each file is a regenerated-on-every-test-run auth-call-tree / budget snapshot (
test_snapshots/test_upgrade/test_init_upgrade_admin_fails_before_initialize.1.jsonetc.), and a single one- or two-line functional change to a contract routinely produces 100+ line diffs across dozens of these files in the same PR, since ledger sequence numbers, event ordering, and cost accounting shift with almost any change.Why this matters
This has been directly observed slowing down review this cycle: every contract-touching PR fixed in this session (#228, #219, #165's contract pieces, #187, #215) carried large `tes
Auto-generated by GrantFox Task Executor