Skip to content

Security: Path traversal/arbitrary file write risk in replay cache key handling #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Security: Path traversal/arbitrary file write risk in replay cache key handling #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion lumibot/components/agents/replay_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import hashlib
import json
import os
import re
from datetime import date, datetime
from decimal import Decimal
from enum import Enum
Expand Down Expand Up @@ -49,6 +50,9 @@ def _cache_root() -> Path:
return Path(os.environ.get("LUMIBOT_CACHE_FOLDER") or LUMIBOT_CACHE_FOLDER)


_KEY_RE = re.compile(r"^[a-f0-9]{64}$")


class AgentReplayCache:
def __init__(self) -> None:
self.root = _cache_root() / "agent_runtime" / "replay"
Expand All @@ -61,7 +65,16 @@ def compute_key(self, payload: dict[str, Any]) -> str:
return hashlib.sha256(encoded.encode("utf-8")).hexdigest()

def _path_for(self, key: str) -> Path:
return self.root / key[:2] / f"{key}.json.gz"
if not _KEY_RE.fullmatch(key):
raise ValueError("Invalid replay cache key")
path = self.root / key[:2] / f"{key}.json.gz"
resolved_root = self.root.resolve()
resolved_path = path.resolve()
try:
resolved_path.relative_to(resolved_root)
except ValueError as exc:
raise ValueError("Invalid replay cache key") from exc
return resolved_path

def load(self, key: str) -> dict[str, Any] | None:
path = self._path_for(key)
Expand Down