Fix and simplify st-urlhandle - #370
Open
jdujava wants to merge 1 commit into
Open
Conversation
Improvements:
- visually simplified regexes by splitting to url and magnet parts
- properly capture "www.___" urls
- slightly more robust line concatenation, which preserves
the newlines on empty lines -> before, links at the end of
the lines would often become corrupted, now at least empty
lines can guard the link
- fixed removing of the ending punctuation
(removing "?" did not work previously)
Signed-off-by: Jonas Dujava <jonas.dujava@gmail.com>
|
is it possible to modify the regex to match the full url when quotations or non-english characters are present? eg: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements: