sync(acehack→lfg): gate.yml — macos-26 back to per-PR cadence (unblocks queue) - #666
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d557a7fba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Forward-ports .github/workflows/gate.yml changes intended to restore macos-26 to per-PR CI cadence so branch protection checks can pass and the LFG PR queue unblocks.
Changes:
- Removes the dynamic
matrix-setupsplit and runsbuild-and-testonmacos-26for PR events. - Updates lint jobs to
ubuntu-24.04and adds caching/retry wrappers aroundtools/setup/install.shfor several lint jobs. - Changes the Semgrep job to install via
actions/setup-python+pip install semgrep(bypassing the mise/uv toolchain).
LFG main's gate.yml uses dynamic matrix-setup that excludes macos-26
from pull_request + merge_group events ("Linux production legs
only"). Branch protection on main requires `build-and-test (macos-26)`
as a status check, so every LFG PR is structurally BLOCKED.
Aaron's correction (2026-04-28T16:30Z): "we pull out mac and codeql
to merge to main time instead of per pr, and then moved it back to
per pr, I think you just have some staleness and not update to date
with the move back to per per".
This PR makes the surgical edit: matrix-setup's PR/merge_group
branch now outputs `[ubuntu-24.04, ubuntu-24.04-arm, macos-26]`
(was `[ubuntu-24.04, ubuntu-24.04-arm]`). Comment updated to
reflect the cadence change.
Initial draft full-file copy from AceHack was correctly flagged by
Codex P2: AceHack's gate.yml has the older Semgrep bootstrap
(`pip install semgrep`) while LFG already migrated to mise-pinned
`pipx:semgrep` via three-way-parity install.sh (resolves Scorecard
PinnedDependenciesID #17/#18). LFG's improvement preserved by
basing this surgical patch on LFG main rather than AceHack.
Composes with:
- PR #657 (originally-queued forward-sync — becomes redundant)
- task #306 (cadence-fast revisit)
- BLOCKED LFG queue: #655..#666 awaiting this unblock
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AceHack
force-pushed
the
sync/forward-gate-yml-macos-26-back-to-per-pr
branch
from
April 28, 2026 16:13
1d557a7 to
e352411
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-ports gate.yml from AceHack to LFG. AceHack already moved macos-26 + Analyze (csharp) back to per-PR cadence; LFG is stale on the prior cadence-split (matrix-setup dynamic switch that excludes macos-26 from pull_request events).
Effect: unblocks the structurally-blocked LFG queue. Branch protection requires
build-and-test (macos-26)as a status check; LFG gate.yml's PR-event matrix didn't include it. After this PR lands, PR-events run macos-26 directly.Aaron's correction
Composes with
🤖 Generated with Claude Code