Skip to content

hygiene(_patterns.md): document Otto-250-canonical vs Otto-268-abbreviated shape divergence #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AceHack merged 2 commits into from
Apr 25, 2026
Merged

hygiene(_patterns.md): document Otto-250-canonical vs Otto-268-abbreviated shape divergence #467

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feb47a0
hygiene(_patterns.md): document Otto-250-canonical vs Otto-268-abbrev…
AceHack Apr 25, 2026
e7b54a0
hygiene(#467): fix 4 Copilot findings on shape-divergence section
AceHack Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions docs/pr-preservation/_patterns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,75 @@ into one-line stale-resolved-by-reality replies:

---

## Known divergence: drain-log shape (Otto-250 canonical vs Otto-268 abbreviated)

The drain-log corpus has two co-existing shapes:

**Canonical Otto-250 shape** (used in older drain-logs like
`108-drain-log.md`, `247-drain-log.md`):

```markdown
## Thread N — `path/file.md:LINE` — heading

- Reviewer: <handle>
- Thread ID: `PRRT_...`
- Severity: P0/P1/P2

### Original comment (verbatim)

> verbatim quote of reviewer's full text

### Outcome — FIX / STALE-RESOLVED-BY-REALITY / ...

Discussion + commit SHA where fix landed.

### Reply (verbatim)

> verbatim quote of the reply that resolved the thread.
```

**Abbreviated Otto-268 shape** (used across drain-logs #437-#465
landed during the 2026-04-25 backfill wave):
Comment thread
AceHack marked this conversation as resolved.
Outdated

```markdown
### Thread N — `:LINE` — short description (Reviewer P-class)

- Reviewer: <handle>
- Thread ID: `PRRT_...`
Comment thread
AceHack marked this conversation as resolved.
Outdated
- Severity: P0/P1/P2
- Outcome: **CLASS** — short prose explanation. Commit `SHA`.
```

The abbreviated shape preserves Thread ID + severity + outcome
class + commit SHA but compresses verbatim reviewer/reply text into
short prose. Substance is preserved; the multi-section structure
and verbatim preservation are not.
Comment thread
AceHack marked this conversation as resolved.
Outdated

**Maintainer-decision pending** — three options:

(a) **Rewrite** the 22+ Otto-268-wave drain-logs to canonical
shape with verbatim reviewer/reply. Highest faithfulness; high
churn (~5-8 hours).
Comment thread
AceHack marked this conversation as resolved.
Outdated

(b) **Accept divergence** — document both shapes here as valid
(this section); keep abbreviated shape for low-thread-count or
bulk-backfill logs; use canonical for high-thread-count or
substantive drains where verbatim preservation pays back.

(c) **Hybrid** — backfill canonical shape only for the
highest-substantive logs (#206 math content, #268 BLAKE3
crypto-protocol, #226 algorithm spec, #85 ADR draft) where
verbatim training-signal value is highest; leave low-substance
logs in abbreviated shape.

This file is the synthesis-index where the maintainer-decision
should land + propagate via the canonical reference. Until
then, drain-runners writing future logs should default to
canonical shape; existing Otto-268-wave logs stay
abbreviated-with-this-known-divergence-note.

---

## How to update this file

When a new drain-log lands in `docs/pr-preservation/`:
Expand Down
Loading